1885146 - Tab hover preview panel colors don't integrate well with themes

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Dão Gottwald [:dao]]

Attachment: Screenshot from 2024-03-13 14-49-08.png

Bug 1884417 tweaked these colors, but they still seem to tailored specifically for our Dark and Light themes, and will feel off with other themes. On Linux this even applies to our default system theme in dark mode, see attached screenshot.

Comment 1

[DJ]

Attachment: Bug 1885146 - use preexisting colors for tab preview component. r?#desktop-theme-reviewers

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Probably we can close this as a dupe of bug 1890397 unless you think this needs more work?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1885146 - Make line-clamp on blocks work in chrome contexts. r=dholbert,#layout

This flag is tested separately, I don't think this deserves its own
test, probably...

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Actually we should probably just use the arrowpanel background. Otherwise themes like https://addons.mozilla.org/en-US/firefox/addon/cosmos-soft/reviews/ (I just happened to have that on a local build for testing something else, not hand-picked) show semi-transparent backgrounds which look pretty weird.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1885146 - Use line-clamp rather than max-height to crop tab preview titles. r=dwalker,#theme

Comment 6

[Phabricator Automation]

Comment on attachment 9396420 [details]
Bug 1885146 - Make line-clamp on blocks work in chrome contexts. r=dholbert,#layout

Revision D207342 was moved to bug 1891210. Setting attachment 9396420 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9396424 [details]
Bug 1885146 - Use line-clamp rather than max-height to crop tab preview titles. r=dwalker,#theme

Revision D207343 was moved to bug 1891210. Setting attachment 9396424 [details] to obsolete.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1885146 - Use arrowpanel background / colors rather than tab selected colors, to prevent issues with semi-transparent tab selected colors. r=#theme

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19ece7e0ea45
Use arrowpanel background / colors rather than tab selected colors, to prevent issues with semi-transparent tab selected colors. r=dwalker

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/19ece7e0ea45