Tab hover preview panel colors don't integrate well with themes
Categories
(Firefox :: Tabbed Browser, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox127 | --- | fixed |
People
(Reporter: dao, Assigned: dwalker)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 3 obsolete files)
Bug 1884417 tweaked these colors, but they still seem to tailored specifically for our Dark and Light themes, and will feel off with other themes. On Linux this even applies to our default system theme in dark mode, see attached screenshot.
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Comment 1•6 months ago
|
||
Updated•6 months ago
|
Updated•6 months ago
|
Updated•6 months ago
|
Comment 2•6 months ago
|
||
Probably we can close this as a dupe of bug 1890397 unless you think this needs more work?
Comment 3•6 months ago
|
||
This flag is tested separately, I don't think this deserves its own
test, probably...
Comment 4•6 months ago
|
||
Actually we should probably just use the arrowpanel background. Otherwise themes like https://addons.mozilla.org/en-US/firefox/addon/cosmos-soft/reviews/ (I just happened to have that on a local build for testing something else, not hand-picked) show semi-transparent backgrounds which look pretty weird.
Comment 5•6 months ago
|
||
Comment 6•6 months ago
|
||
Comment on attachment 9396420 [details]
Bug 1885146 - Make line-clamp on blocks work in chrome contexts. r=dholbert,#layout
Revision D207342 was moved to bug 1891210. Setting attachment 9396420 [details] to obsolete.
Comment 7•6 months ago
|
||
Comment on attachment 9396424 [details]
Bug 1885146 - Use line-clamp rather than max-height to crop tab preview titles. r=dwalker,#theme
Revision D207343 was moved to bug 1891210. Setting attachment 9396424 [details] to obsolete.
Comment 8•6 months ago
|
||
Comment 10•6 months ago
|
||
Comment 11•6 months ago
|
||
bugherder |
Reporter | ||
Updated•6 months ago
|
Updated•6 months ago
|
Description
•