1891819 - Tab preview text can still appear with some transparency with certain themes installed, after bug 1885146

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Itiel]

Attachment: Screenshot

This can still happen with https://addons.mozilla.org/he/firefox/addon/noctourniquet-orange-fanmade/, see attached.

This seems to happen only on panels which do not have a <panelview> in their markup, so for example this also happens to the bookmark popup.
This is because of this rule:
https://searchfox.org/mozilla-central/rev/23ad6bdb310c9a46e6f37885b0d88ec5da3c00f7/browser/themes/shared/customizableui/panelUI-shared.css#173,175
(technically it's possible for panels to still be semi transparent after this bug will be fixed, but very much unlikely to be noticeable)

This also happens to menupopups, for which inserting a <panelview> to the markup won't make sense...

@emilio, what do you think? I think either 1) make it so all panels will have panelviews, or 2) somehow drop that background declaration in the rule above so there will only be 1 layer of background (and so all panels will be semi-transparent [maybe as the theme author intended in the first place? not sure how this works behind the scenes]).
Approach 2 makes it so panels will be consistent with menupopups in this regard.

Or maybe you have a different idea?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Yeah, probably remove that <panelview> rule, then either:

• Leave as is.
• Change this to remove the alpha channel.

Probably 1 is fine, the theme author specified a semi-transparent background anyways.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1891819 - Remove redundant background from panelview. r=#theme

This causes inconsistent popup backgrounds if a theme uses a
semi-transparent popup color.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/123e0c272c21
Remove redundant background from panelview. r=desktop-theme-reviewers,dao

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/123e0c272c21