1885353 - [RNP] Update to v0.17.1

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Rob Lemley [:rjl]]

RNP is preparing a new release v0.17.1. ETA is unknown but there is a ni4-release-v0.17.1 branch and a PR that can be used to work out any issues. There are some build changes needed for sure.

Comment 1

[Kai Engert (:KaiE:)]

Thanks Rob for being proactive!

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1885353 - [RNP] Update vendoring config for RNP v0.17.1. r=#thunderbird-build-system-reviewers

The two patches will not be needed with v0.17.1.
Adding the rnp_symbols script to pick up any export changes.
"libsexp" is renamed to "libsexpp", so the vendoring will need
to account for that.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1885353 - [RNP] Update to v0.17.1. r=kaie

This is as of 2023-03-14 rev 3981498594310ee6df72be402b316ee2249d854c
from the ni4-release-v0.17.1 branch.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1885353 - [RNP] Update moz.build for v0.17.1. r=#thunderbird-build-system-reviewers

For the libsexp -> libsexpp rename.

Comment 5

[Rob Lemley [:rjl]]

Try build for the WIP patches: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=b2cae3e0af3de48dbd68635402714a72c37fba32

Comment 6

[Rob Lemley [:rjl]]

D204666 is the only piece that should change when a release is cut. Apply D204665, run mach vendor as in README.rnp. Commit, include the "Differential Revision:" line from D204666's commit message, then apply D204667.

Comment 7

[Rob Lemley [:rjl]]

RNP v0.17.1 was tagged a few days ago, but there is no source tar file in the Github repository to download. It looks like PR 2228 might be addressing this. I'll hold off on updating for now.

Comment 8

[Kai Engert (:KaiE:)]

I've received a release announcement from github.
Rob, do you want to submit final patches for me to review?

Comment 9

[Kai Engert (:KaiE:)]

Thanks Rob!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a66267c7b132
[RNP] Update moz.build for v0.17.1. r=kaie
https://hg.mozilla.org/comm-central/rev/f535cff41232
[RNP] Update to v0.17.1. r=kaie
https://hg.mozilla.org/comm-central/rev/f552c0daf666
[RNP] Update vendoring config for RNP v0.17.1. r=kaie

Comment 11

[Kai Engert (:KaiE:)]

Let's uplift to beta quickly.

Comment 12

[Kai Engert (:KaiE:)]

Comment on attachment 9391307 [details]
Bug 1885353 - [RNP] Update vendoring config for RNP v0.17.1. r=#thunderbird-build-system-reviewers

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: bugs in OpenPGP unfixed
Testing completed (on c-c, etc.): ongoing, needs Beta testing
Risk to taking this patch (and alternatives if risky): medium

Comment 13

[Kai Engert (:KaiE:)]

FYI, I'm locally running a 115.x build with RNP v0.17.1 for testing purposes.
(The vendoring script doesn't work on the esr 115 branch, I've simply copied over the full rnp directory from comm-central.)

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9391307 [details]
Bug 1885353 - [RNP] Update vendoring config for RNP v0.17.1. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9391308 [details]
Bug 1885353 - [RNP] Update to v0.17.1. r=kaie

[Triage Comment]
Approved for beta

Comment 16

[Wayne Mery (:wsmwk)]

Comment on attachment 9391309 [details]
Bug 1885353 - [RNP] Update moz.build for v0.17.1. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for beta

Comment 17

[Daniel Darnell [:dandarnell]]

Thunderbird 127.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/d7911767fd2a
https://hg.mozilla.org/releases/comm-beta/rev/fdb7dfd98fa6
https://hg.mozilla.org/releases/comm-beta/rev/febc9697b7f9

Comment 18

[Rob Lemley [:rjl]]

Attachment: Bug 1885353 - Set MIN_RNP_VERSION to 0.17.1. r=kaie

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/33ec41b04d19
Set MIN_RNP_VERSION to 0.17.1. r=kaie

Comment 20

[Wayne Mery (:wsmwk)]

Comment on attachment 9403776 [details]
Bug 1885353 - Set MIN_RNP_VERSION to 0.17.1. r=kaie

[Triage Comment]
Approved for beta

Comment 21

[Kai Engert (:KaiE:)]

Are we ready to uplift to 115.x, as some users are waiting for its fixes?

Or do we prefer to wait until after 128 has been released and no major bugs are being reported?

Comment 22

[Wayne Mery (:wsmwk)]

The next opportunity is likely 116.13.0 115.13.0 in July. Unless the security implications mean it's needed earlier.

Since a signifcant version 115 user population will live on past August ISTM we should take this for 115. Also just on general princples to have security parity with 128.

Comment 23

[Kai Engert (:KaiE:)]

Comment on attachment 9391308 [details]
Bug 1885353 - [RNP] Update to v0.17.1. r=kaie

[Approval Request Comment]

see comment 12

Comment 24

[Wayne Mery (:wsmwk)]

Comment on attachment 9391308 [details]
Bug 1885353 - [RNP] Update to v0.17.1. r=kaie

[Triage Comment]
Approved for esr115

Comment 25

[Daniel Darnell [:dandarnell]]

Thunderbird 115.13.0:
https://hg.mozilla.org/releases/comm-esr115/rev/d3731f1a44e6

Comment 26

[Daniel Darnell [:dandarnell]]

Backed out changeset d3731f1a44e6 from Thunderbird 115.13.0:
https://hg.mozilla.org/releases/comm-esr115/rev/8a519224c886

Comment 27

[Daniel Darnell [:dandarnell]]

Thunderbird 115.13.0:
https://hg.mozilla.org/releases/comm-esr115/rev/5df855f1d974
https://hg.mozilla.org/releases/comm-esr115/rev/d9da3fd85ad3
https://hg.mozilla.org/releases/comm-esr115/rev/985354d79674
https://hg.mozilla.org/releases/comm-esr115/rev/414c23cfc30f