Closed Bug 1885499 Opened 10 months ago Closed 9 months ago

[win] No shortcuts are created in the Start Menu Program folder after selecting “No” on the User Account Control (UAC) prompt

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Platform:
Desktop
Windows
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox123 --- wontfix
firefox124 --- wontfix
firefox125 --- wontfix
firefox126 --- wontfix
firefox127 --- verified

People

(Reporter: atrif, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Found in

  • 125.0a1 (2024-03-14)

Affected versions

  • 125.0a1 (2024-03-14)
  • 124.0
  • 123.0.1

Tested platforms

  • Affected platforms: Windows 10x64, Windows 11
  • Unaffected platforms: macOS 12, Ubuntu

Steps to reproduce

  1. Download and open Firefox full installer from https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
  2. Click No on the UAC prompt and install Firefox.
  3. Verify that the Shortcuts are created inside the Start Menu Program folder.

Expected result

  • The shortcuts are created inside the Start Menu Program folder.

Actual result

  • No shortcuts are created inside the Start Menu Program folder.

Regression range

Additional notes

  • This works as expected when clicking Yes on the UAC prompt.

:nshukla could this be caused by bug 1862450?

status-firefox123: affected → wontfix
Flags: needinfo?(nshukla)

I haven't tested it specifically but after looking at the code I can't see why that would be the cause. We are planning on removing the protocol code for unrelated reasons in Fx126 anyway so if that's the cause this should resolve itself.

Flags: needinfo?(nshukla)

It's fairly unlikely this is caused by that bug / changes.
Does this happen when the response is yes to the UAC prompt?

Could be a Windows change. They've been making changes lately to what they'll allow. Can QA confirm that this is happening on older builds of Windows please?

(In reply to Michael Hughes from comment #3)

It's fairly unlikely this is caused by that bug / changes.
Does this happen when the response is yes to the UAC prompt?

Could be a Windows change. They've been making changes lately to what they'll allow. Can QA confirm that this is happening on older builds of Windows please?

This does not happen when clicking Yes in the UAC prompt. I tried this on Windows 10x86 (1809.17763) and this still reproduces with 125.0b1. Attached a screen recording: link.

This line breaks the shortcut creation for per user install. SetShellVarContext all will change $SMPROGRAMS to all user programs folder which is writable only when UAC elevated. So CreateShortCut will fail.

So bug 1862450 is definitely the regressor.

Regressed by: 1862450

Set release status flags based on info from the regressing bug 1862450

status-firefox127: --- → affected

(In reply to Nipun Shukla from comment #2)

We are planning on removing the protocol code for unrelated reasons in Fx126 anyway so if that's the cause this should resolve itself.

Fx126 is now in beta, can you confirm this landed and share the bug tracking it?
Wondering if this should be marked as fixed for Fx126

Flags: needinfo?(nshukla)

I just got reviewer approval for https://bugzilla.mozilla.org/show_bug.cgi?id=1889232 and plan on pushing it soon which should fix this issue. Unfortunately, it looks we missed the train for Fx126 however should be good to go for 127.

Flags: needinfo?(nshukla)

Confirmed that shortcuts are created in Start Menu after selecting “No” on the User Account Control (UAC) prompt with the latest installer.

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED

(In reply to Masatoshi Kimura [:emk] from comment #10)

Confirmed that shortcuts are created in Start Menu after selecting “No” on the User Account Control (UAC) prompt with the latest installer.

Confirming this as well with Firefox 127.0a1 (20240512212637) on Windows 10x64 and Windows 11.

Status: RESOLVED → VERIFIED
status-firefox127: fixed → verified
You need to log in before you can comment on or make changes to this bug.