1889232 - Delete firefox-bridge and firefox-private-bridge protocol registration

Status: RESOLVED FIXED

(Firefox :: Shell Integration, task)

Comment 1

[Nipun Shukla]

Attachment: Bug 1889232 - Removed firefox-bridge and firefox-private-bridge protocol creation r=mhughes,Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/977027e73ec0
Removed firefox-bridge and firefox-private-bridge protocol creation r=mhughes,Gijs,firefox-desktop-core-reviewers

Comment 3

[Iulian Moraru]

Backed out for causing windows mass failures.

• Push with failures

• Failure log example 1

• Failure log example 2

• Failure log example 3

• Failure log example 4
  and also xpcshell failure on test_FirefoxBridgeExtensionUtils.js and windows build bustages like this.

• Backout link

Comment 4

[Nipun Shukla]

Accidentally forgot to push changes which caused test failure in test_FirefoxBridgeExtensionUtils.js. Fixed Marionette failures by removing additional use of deleted function in BrowserGlue. Started try build and will re-land assuming it passes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10dbe5ae6a79
Removed firefox-bridge and firefox-private-bridge protocol creation r=mhughes,Gijs,firefox-desktop-core-reviewers

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/10dbe5ae6a79

Comment 7

[Rob Wu [:robwu]]

These protocols were originally added in bug 1880368 as a replacement for the initial iteration of the firefox / firefox-private protocols in bug 1862450.

The protocols are removed because they did not result in the desired user experience; the intended result was to make it easier to open Firefox from Chrome, but in reality Chrome would prompt a user to confirm that they want to open the external protocol handler, attributed to the chrome-extension:-origin of the extension making the request. An example of this flow is shown in this document: https://docs.google.com/document/d/1I1WY5lV62zDy86CCceBXdQm-4PL18VKvXy8p6UmuA7g/edit

Instead of protocol handlers, native messaging became the foundation for the feature. The pref tied to it was prepared to go live in bug 1889718, but never actually went live. If the pref would have become enabled, then Firefox would have registered itself as a native messaging host that the companion Chrome extension could use to launch Firefox.