1885671 - Move decoder module's initialization off the main thread

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

We call it the first time during GPUParent::RecvInit and then a second time in GPUParent::RecvUpdateVar.

https://share.firefox.dev/3IClfnt

Perhaps we can do the init async?

Comment 1

[Jeff Muizelaar [:jrmuizel]]

alwu, thoughts on how we could improve this?

Comment 2

[Alastor Wu [:alwu]]

I will make them unblock the startup.

Comment 3

[Alastor Wu [:alwu]]

Actually we already made the initialization async in GPUParent::RecvInit(), so it shouldn't block the start-up of the GPU process. How do you define a start-up process? Although the initialization still takes some time in GPUParent::RecvUpdateVar, UpdateVar is an async function so that it shouldn't really block the start-up as well (as no one expects the result of that function in order to finish the start-up).

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I think what's happening is that we end up blocking a subsequent sync message here:
https://searchfox.org/mozilla-central/rev/f8258e49f277c1c881c5c0da95f463dd12b7397e/widget/windows/CompositorWidgetChild.cpp#50

https://share.firefox.dev/3VF9ggr

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1885671 - part1 : run the method of getting codec supported on the background thread in order not to block the main thread.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ea681f466b
run the method of getting codec supported on the background thread in order not to block the main thread. r=jrmuizel

Comment 8

[Cristina Horotan [:chorotan]]

Backed out changeset 68ea681f466b (bug 1885671) for causing xpcshell crashes at test_privacy_transition.js

Backout: https://hg.mozilla.org/integration/autoland/rev/97de770971be33fd22261a0abab98211db128062

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=EPBUrMTARtWQUt_n8ODvUA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=68ea681f466b03b4ef17dc5647835ca1a28befa1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=454748899&repo=autoland&lineNumber=2158

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1885671 - part2 : do not return a MediaFoundationInitializer if shutdown has already started.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1189be6d8d0e
run the method of getting codec supported on the background thread in order not to block the main thread. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/0c53f738aa7f
part2 : do not return a MediaFoundationInitializer if shutdown has already started. r=media-playback-reviewers,padenot

Comment 11

[Serban Stanca [:SerbanS]]

Backed out for causing Windows xpcshell assertion failures on ClearOnShutdown.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: Assertion failure: false (ClearOnShutdown for phase that already was cleared), at /builds/worker/checkouts/gecko/xpcom/base/ClearOnShutdown.cpp:20

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/c715b8606805
Backed out 2 changesets for causing Windows xpcshell assertion failures on ClearOnShutdown.cpp. CLOSED TREE

Comment 13

[tszentpeteri]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/bbf6abc576b8e55f9a3d5ba93adbf294ab538695

Comment 14

[Alastor Wu [:alwu]]

Attachment: Bug 1885671 - part3 : initialize Media Foundation earlier for GPU process.

This is used to fix the failures [1] on Windows xpcshell test on the try
server. As we've changed the timing of initailizing in previous patches,
that delays the timing of setting clean-up for MediaFoundationInitializer.

MediaFoundationInitializer has to be clean on MTA thread, but on the try
server, when the runnable for clean-up being dispatched on the main
thread, the MTA thread has been shutdowned.

Therefore, we would like to run the initialization earlier to ensure the
clean-up can be setup properly.

[1] https://treeherder.mozilla.org/logviewer?job_id=455059875&repo=autoland&lineNumber=2090

Depends on D207773

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8444632ca3ad
part1 : run the method of getting codec supported on the background thread in order not to block the main thread. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/883f7db28d01
part2 : do not return a MediaFoundationInitializer if shutdown has already started. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/399ca207b66f
part3 : initialize Media Foundation earlier for GPU process. r=media-playback-reviewers,padenot

Comment 16

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/8444632ca3ad
https://hg.mozilla.org/mozilla-central/rev/883f7db28d01
https://hg.mozilla.org/mozilla-central/rev/399ca207b66f