Closed Bug 1885894 Opened 9 months ago Closed 7 months ago

Remove sidebar persistence off of XULstore

Categories

(Firefox :: Sidebar, task)

task

Tracking

()

RESOLVED FIXED
127 Branch
Tracking Status
firefox127 --- fixed

People

(Reporter: sclements, Assigned: nsharpley)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(1 file)

The SidebarUI state persistence (whether its open or closed) across windows is stored in two places - XULstore here and session restore here.

In session store there's a "sidebar" attribute on the winData object and even in the case of a deferred restore we should be able to modify what attributes are restored. restoreDimensions is called in either case, and I think we'll need to figure out what causes the sidebar attr to be truthy or not: https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/sessionstore/SessionStore.sys.mjs#5967-5973. We might need to modify either of these: hhttps://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/sessionstore/SessionStore.sys.mjs#65,98

Assignee: nobody → nsharpley
Blocks: 1891777
Blocks: 1892033
Attachment #9395807 - Attachment description: WIP: Bug 1885894 - Remove sidebar persistence from XULStore → Bug 1885894 - Remove sidebar persistence from XULStore r=#fxview-reviewers
Attachment #9395807 - Attachment description: Bug 1885894 - Remove sidebar persistence from XULStore r=#fxview-reviewers → WIP: Bug 1885894 - Remove sidebar persistence from XULStore r=#fxview-reviewers
Attachment #9395807 - Attachment description: WIP: Bug 1885894 - Remove sidebar persistence from XULStore r=#fxview-reviewers → Bug 1885894 - Remove sidebar persistence from XULStore r=#fxview-reviewers
Attachment #9395807 - Attachment description: Bug 1885894 - Remove sidebar persistence from XULStore r=#fxview-reviewers → Bug 1885894 - Remove sidebar persistence from XULStore r=#sidebar-reviewers
Pushed by nsharpley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e86e777fced4 Remove sidebar persistence from XULStore r=sessionstore-reviewers,backup-reviewers,sidebar-reviewers,Gijs,mconley,sfoster,sclements
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Regressions: 1908019
Regressions: 1922777
Regressions: 1921536
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: