1886409 - Add close remote tab for synced tabs in sidebar

Status: RESOLVED DUPLICATE of bug 1911626

(Firefox :: Sidebar, task)

Description

[Sarah Clements [:sclements]]

This bug should handle adding the close remote device hover state and adding it to the right-click menu per the spec.

• telemetry is TBD
• right-click menu changes will be added in bug 1886408
• responsive breakpoints handled in bug 1906619
• style changes handled in bug 1886847

Edit: updated this based on the spec and Jonathan's comments below.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

From feedback on https://phabricator.services.mozilla.com/D205646:

• With the sidebar open and this synced tabs panel visible, I logged in to my fxa account on my phone. The new device didn't show up until I clicked the fxa toolbar - which IIRC forces a sync.
• There's no right-click/context menu options here. The legacy implementation has a bunch of tab context actions. See bug 1254544
• There's no middle-click action. The legacy implementation opens the tab - see bug 1288247
• The device heading has no right-click/context menu options. In the legacy implementation this offers "Open all tabs", "Manage devices", "Sync now" options.
• I'm not sure what should be happening with focus when I select a tab from the sidebar and click/open it from the keyboard. It feels like shift+tab should put me back in the sidebar where I just was, but this isn't working in the existing sidebar either. Maybe another good thing to look into and chat with the a11y folks about in a follow-up bug.

Comment 2

[Sarah Clements [:sclements]]

(In reply to Jonathan Sudiaman [:jsudiaman] from comment #1)

From feedback on https://phabricator.services.mozilla.com/D205646:

• With the sidebar open and this synced tabs panel visible, I logged in to my fxa account on my phone. The new device didn't show up until I clicked the fxa toolbar - which IIRC forces a sync.
• There's no right-click/context menu options here. The legacy implementation has a bunch of tab context actions. See bug 1254544
• There's no middle-click action. The legacy implementation opens the tab - see bug 1288247
• The device heading has no right-click/context menu options. In the legacy implementation this offers "Open all tabs", "Manage devices", "Sync now" options.
• I'm not sure what should be happening with focus when I select a tab from the sidebar and click/open it from the keyboard. It feels like shift+tab should put me back in the sidebar where I just was, but this isn't working in the existing sidebar either. Maybe another good thing to look into and chat with the a11y folks about in a follow-up bug.

Jonathan, I think most of these issues have been addressed already. Is there anything that is still broken that we should spin out into a separate bug? I'm thinking to close this out since I moved the "Add close remote tab for synced tabs in sidebar" to bug 1911626.

Comment 3

[Jonathan Sudiaman [:jsudiaman]]

This bug was previously used as a "wish list" for the sidebar. Now that we have specs to refer to, I agree that this bug should be closed out, and further issues should be reported in their own bugs.