1886566 - Site content is not visible on qceservices.quezoncity.gov.ph

Status: ASSIGNED

(Web Compatibility :: Interventions, defect, P1)

Description

[Ksenia Berezina [:ksenia]]

Moving https://github.com/webcompat/web-bugs/issues/130868 to this bug for tracking purposes

Comment 1

[Ksenia Berezina [:ksenia]]

The content is displayed via iframe and site is using -webkit-fill-available; to set its height:
<iframe src="https://qceservices.quezoncity.gov.ph/index.php/qcvaxeasy/qcvaxeasy_landing_page" onload="whenLoaded()" class="responsive-iframe qc_vax_iframe" style="height:-webkit-fill-available;width:100%" allow="camera;" id="qcid_iframe"> </iframe>

-webkit-fill-available; is not supported in Firefox, see https://bugzilla.mozilla.org/show_bug.cgi?id=1872755

We could contact the site to ask if they could change the height property to 100% instead.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1886566 - add a CSS intervention to show the main iframe on qceservices.quezoncity.gov.ph/qcvaxeasy; r?denschub

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00bd39b32a73
add a CSS intervention to show the main iframe on qceservices.quezoncity.gov.ph/qcvaxeasy; r=denschub,webcompat-reviewers

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/00bd39b32a73

Comment 5

[Daniel Holbert [:dholbert]]

Noticed while skimming webcompat bugs on -webkit-fill-available: this particular intervention isn't working (possibly it never worked?)

Per comment 1, the height: -webkit-fill-available; is in a style attribute, which is higher-precedence than the style rule in our injected stylesheet ( https://searchfox.org/firefox-main/source/browser/extensions/webcompat/injections/css/bug1886566-quezoncity.gov.ph-iframe-height.css )

Probably we need to add !important in order for the intervention to take effect here. Though also, -webkit-fill-available support will hopefully ship soon, so maybe no sense in shipping an update here at this point.

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #5)

Though also, -webkit-fill-available support will hopefully ship soon, so maybe no sense in shipping an update here at this point.

Following up: this should be fixed by the patch that I've landed in bug 1988938. I'll plan to retest in tomorrow's Nightly, with the (perhaps-ineffective) intervention disabled just to be sure, and I'll close after confirming that it's fixed.

--> Removing dependency on bug 1872755 (which remains open and tracks broader support that's not needed here).

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

Hmm, this one actually isn't fixed by the pref-flip in bug 1988938; in fact, the site went from working (with the intervention in yesterday's Nightly) to broken in today's Nightly.

That's because:
(a) the site's height: -webkit-fill-available is higher-precedence than our intervention, due to being in an inline style="..." attribute
(b) apparently in quirks-mode, Chrome resolves height: -webkit-fill-available on inline-level elements with unconstrained size on their containing block. (They resolve it against the viewport height, it looks like.) I'm attaching a testcase to demonstrate this behavior (we render the blue area as being 150px tall, the default for iframes; Chrome renders it as filling the viewport).

I'll file a bug on matching the behavior in (b); but in the meantime, I think we need to update our intervention here to add !important on our height:100% decl.

Comment 8

[Daniel Holbert [:dholbert]]

(though I suppose if we can fix (b) quickly enough, as we probably should, then we don't need to worry about updating the intervention.)

Comment 9

[Daniel Holbert [:dholbert]]

(side note: I needed to use a VPN set to the Philippines in order to test the site here. Before I activated that VPN, I just got a never-ending stream of recaptcha prompts.)

Comment 10

[Daniel Holbert [:dholbert]]

I confirmed that:

• this bug still affects Nightly if I disable the intervention.
• ...but it's fixed in a build with my patch on bug 1989365.

(In reply to Daniel Holbert [:dholbert] from comment #9)

(side note: I needed to use a VPN set to the Philippines in order to test the site here. Before I activated that VPN, I just got a never-ending stream of recaptcha prompts.)

This^ is no longer an issue; I just had to solve 1-2 recaptcha puzzles and then made it through to the site, no VPN needed.

Comment 11

[Thomas Wisniewski [:twisniewski]]

Since bug 1989365 is fixed in 146, I will adjust the intervention so it doesn't run on 146 up when the related pref is true.

Comment 12

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1886566 - disable our webcompat intervention for qceservices.quezoncity.gov.ph where it is no longer needed; r?ksenia

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bdb5a318f084
https://hg.mozilla.org/integration/autoland/rev/1269886174e0
disable our webcompat intervention for qceservices.quezoncity.gov.ph where it is no longer needed; r=ksenia,webcompat-reviewers

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1269886174e0