1988938 - Enable 'layout.css.webkit-fill-available.enabled' (support -webkit-fill-available in 'height' and 'width')

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Daniel Holbert [:dholbert]]

Filing this bug to enable the layout.css.webkit-fill-available.enabled pref, to support -webkit-fill-available in 'height' and 'width' properties.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1988938: Enable pref 'layout.css.webkit-fill-available.enabled' (to add support for -webkit-fill-available in 'height' and 'width'). r?#layout,#style

WPTs exist in the css/css-sizing/stretch wpt-subdirectory, with naming
"stretch-alias-*". We pass most of these (enough that enabling this legacy
keyword is a net win for webcompat) - this pref-flip doesn't impact their
.ini files because the pref has already been default-enabled for that directory
up until this point.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/35087837632b
https://hg.mozilla.org/integration/autoland/rev/82a884e29ec4
Enable pref 'layout.css.webkit-fill-available.enabled' (to add support for -webkit-fill-available in 'height' and 'width'). r=layout-reviewers,firefox-style-system-reviewers,dshin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5c327a7548ca
https://hg.mozilla.org/integration/autoland/rev/0f53373c2670
Revert (Bug 1988938, Bug 1988301): for causing reftest failures @grid-item-auto-min-size-clamp-007.html.

Comment 5

[agoloman]

Backed out for causing reftest failures @grid-item-auto-min-size-clamp-007.html.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Daniel Holbert [:dholbert]]

For the part of that testcase that's changing its rendering here:

• it was essentially falling back to height:auto behavior (but now actually does something more interesting, with support for this keyword)
• Chrome agrees with our new rendering.

I'm going to add an annotation to disable this pref specifically for that test, and I'll file a followup on fixing up the test (and removing the annotation).

Comment 7

[Daniel Holbert [:dholbert]]

I'm going through the webcompat bugs that we've got hanging off of bug 1872755 and similar bugs; and for those that are fixed by my patch here (enabling the keyword in 'width' or 'height'), I'm moving them to depend on this bug rather than the other one.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/760c6bc3f7df
https://hg.mozilla.org/integration/autoland/rev/d61fef75b716
Enable pref 'layout.css.webkit-fill-available.enabled' (to add support for -webkit-fill-available in 'height' and 'width'). r=layout-reviewers,firefox-style-system-reviewers,dshin

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d61fef75b716

Comment 10

[Pascal Chevrel:pascalc]

Is that something worth mentioning in the tech section of our general release notes or is the documentation in MDN enough? Thanks

Comment 11

[Daniel Holbert [:dholbert]]

Yeah, it's probably worth mentioning.

Release Note Request (optional, but appreciated)
[Why is this notable]: We now support a nonstandard CSS sizing keyword that's used in-the-wild, and our lack-of-support has previously caused site breakage.
[Affects Firefox for Android]: Yes
[Suggested wording]: Firefox now supports the legacy "-webkit-fill-available" keyword as a value for the CSS "width" and "height" properties, to improve rendering of content on the web that uses this keyword. This keyword is an alias for the recently standardized "stretch" keyword (which isn't shipping in Firefox yet).
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/CSS/width#stretch
(That's the MDN snippet on the standard stretch value; it mentions -webkit-fill-available as a prefixed alias in the compatibility section. I couldn't find any more-specific MDN page on specifically the alias itself.)

Comment 12

[Pascal Chevrel:pascalc]

Thanks, note added to our Nightly-only release notes as the stretch keyword isn't shipping yet. here is the Nightly note wording:

Starting with Firefox 145, we now supports the legacy -webkit-fill-available keyword as a value for the CSS width and height properties, to improve rendering of content on the web that uses this keyword. This keyword is an alias for the recently standardized stretch keyword (which isn't shipping in Firefox yet).

Comment 13

[Daniel Holbert [:dholbert]]

Thanks! Looks like that's at https://www.firefox.com/en-US/firefox/145.0a1/releasenotes/

Minor typo, "we now supports" should say "support" (no trailing "s"). Mind fixing?

Comment 14

[Pascal Chevrel:pascalc]

(In reply to Daniel Holbert [:dholbert] from comment #13)

Thanks! Looks like that's at https://www.firefox.com/en-US/firefox/145.0a1/releasenotes/

Minor typo, "we now supports" should say "support" (no trailing "s"). Mind fixing?

Fixed, will be live in 20mn

Comment 15

[Pascal Chevrel:pascalc]

This is riding to beta/release, resetting the flag to keep on the radar for final release notes.

Comment 16

[Brian Thomas Smith [bsmth]]

MDN docs changes can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/41502

Comment 17

[Daniel Holbert [:dholbert]]

pascal: could we back this bug's patch (comment 9) out from 145beta?

(This feature has at least one bug (bug 1990034) and possibly another (bug 1989365) that need fixing before it hits release. I'd been hoping to fix+uplift those to 145beta, but probably at this point the safer option is to turn this off for 145.)

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/fd0c520fcee1
https://hg.mozilla.org/releases/mozilla-beta/rev/f6c77ad748b0

Comment 19

[Pascal Chevrel:pascalc]

(In reply to Daniel Holbert [:dholbert] from comment #17)

pascal: could we back this bug's patch (comment 9) out from 145beta?

(This feature has at least one bug (bug 1990034) and possibly another (bug 1989365) that need fixing before it hits release. I'd been hoping to fix+uplift those to 145beta, but probably at this point the safer option is to turn this off for 145.)

Done, I'll update our release notes documents to remove it from 145 new features

Comment 20

[Daniel Holbert [:dholbert]]

Thanks!

Comment 21

[Pascal Chevrel:pascalc]

Removed from Firefox 145 beta notes (and our draft final 145 notes). Added to 146 nightly notes as a carry over note from 146.
Given that it is still activated by default to ride the trains in 146, I am putting the relnote flag back to make sure we have it on our radar for the next beta/releaser cycle