1886608 - [DNR] Accept rules with unrecognized keys

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P2)

Description

[Rob Wu [:robwu]]

Firefox currently ignores static DNR rules when there are unrecognized properties in the file.

Chrome and Safari ignore these keys, and apply rules that are valid otherwise. In the WECG we reached consensus on ignoring unrecognized keys, so we should implement that. The relevant discussion is tracked at https://github.com/w3c/webextensions/issues/466

One would be inclined to consider adding "additionalProperties": { "$ref": "UnrecognizedProperty" }, to the various rule object definitions in declarative_net_request.json. The issue with that naive implementation is that updateDynamicRules / updateSessionRules would then not throw when a rule is invalid, which would impede feature detection. So we should have manifest-specific behavior.

Fixing bug 1831417 could be an easy way to support this (along with fixing up failing unit tests).

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1886608 - Accept DNR rules with unrecognized keys. r?robwu!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32c5cc8e8dce
Accept DNR rules with unrecognized keys. r=robwu

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/32c5cc8e8dce

Comment 4

[rbloor]

Change are ready for review: Static DNR rules with unrecognized keys loaded #34522