1887063 - Simplify unified toolbar set-up on macOS

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1887063 - Use VibrancyManager / regular CSS to implement the unified toolbar looks. r=mstange,#mac-reviewers

This is simpler given we only have a couple of windows with these looks,
and removes the dual mode of the ToolbarWindow class.

We just draw the title into the window frame and rely on CSS reserving
enough space (exposed as a new -moz-mac-titlebar-height environment
variable).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

FYI, I don't know if thunderbird on macOS has any such windows.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Actually per https://searchfox.org/comm-central/search?path=&q=unified-toolbar-wind I guess not? But worth checking

Comment 4

[Magnus Melin [:mkmelin]]

Thanks, agreed there doesn't seem to be any usage.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/690b15c54c21
Use VibrancyManager / regular CSS to implement the unified toolbar looks. r=mstange,mac-reviewers,desktop-theme-reviewers,places-reviewers,dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4014cb772d7c
Add some missing null-checks.

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing reftest failure on 1291413-1.html and nsCocoaWindow::IsVisible process-crash

Backout link

Push with failures

Failure log // Failure log 2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dd030b8189c
Use VibrancyManager / regular CSS to implement the unified toolbar looks. r=mstange,mac-reviewers,desktop-theme-reviewers,places-reviewers,dao

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6dd030b8189c