1890573 - 3.47% twinopen ext+twinopen:twinopen.html (OSX) regression on Sat March 30 2024

Status: NEW

(Core :: Widget: Cocoa, defect, P5)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push dea770591ed30035f88966bbf45cbbcc6557cdcc. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	twinopen ext+twinopen:twinopen.html	macosx1015-64-shippable-qr	e10s fission stylo webrender	107.62 -> 111.35

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 42092

For more information on performance sheriffing please see our FAQ.

There were 2 regressing bugs in the commit range, this was one and the other was 1887063, but given this patch modified mac we suspected bug 1887063 to be the culprit commit

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1887063

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Would there be any chance of getting before / after profiles? I'm not quite sure what in my patch could've caused it...

What is the right task for running this test on automation? opt-talos-other? opt-talos-g<something>? If I do mach try perf --show-all I don't see this test off hand.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=c50df68b86bea914bc186af2062b741148cac7c4&newProject=try&newRevision=5f96cdd5091f1bcbcff3374527efa87181f62467 is a comparison with a pref flip that should prevent us from running the vibrancy code at all.

Comment 4

[Andrej (:aglavic)]

So for both bug 1887063 and this bug you don't think this could have caused this? Good to know let me double check in the meanwhile

Comment 5

[Emilio Cobos Álvarez (:emilio)]

No, I think bug 1887063 could've definitely caused this, but what I don't understand is why :)

https://hg.mozilla.org/try/rev/89bdf2164fbcef06ebb7c7247294957f393fddb0 does fix this... So the good thing is that, for now at least, this only applies to nightly (not beta / release).

I need to check if bug 1891354 (which should make the relevant code faster) helps here.

Comment 6

[Timothy Nikkel (:tnikkel)]

To generate a profile I usually just find the job for which I'd like a profile in treeherder, select it, and there is a generate profile button on the bottom under the performance tab, that triggers a new job with profiling enabled.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1887063

Comment 8

[Donal Meehan [:dmeehan]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

No, I think bug 1887063 could've definitely caused this, but what I don't understand is why :)

https://hg.mozilla.org/try/rev/89bdf2164fbcef06ebb7c7247294957f393fddb0 does fix this... So the good thing is that, for now at least, this only applies to nightly (not beta / release).

I need to check if bug 1891354 (which should make the relevant code faster) helps here.

Setting Fx126 to disabled, since browser.theme.macos.native-theme is false
:emilio the graph in comment 0 looks the same after Bug 1891354

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Thanks, I don't have any obvious idea off-hand, but this regression is not terribly concerning over all tho (we're making the system do more work when opening a window). It's worth investigating a bit more if we/UX decide to ship the native-looking macOS theme by default.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit BugBot documentation.