1887331 - c-c perma toolkit/components/search/tests/xpcshell/test_search_config_v2_nimbus.js failure after bug 1886061

Status: RESOLVED FIXED

(Firefox :: Search, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=452009229&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ILPj8VbZQsOcmawYuWX_lg/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1887331 - Fix test_search_config_v2_nimbus.js for Thunderbird. r=barret

Thunderbird doesn't have the STUDIES_OPT_OUT_PREF pref.

Comment 2

[Intermittent Failures Robot]

17 failures in 3791 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 17

Platform and build breakdown:

• linux1804-64-qr: 3
  • opt: 2
  • debug: 1
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-64-2009-ccov-qr: 1
  • opt: 1
• windows11-32-2009-qr: 2
  • opt: 1
  • debug: 1
• macosx1015-64-qr: 2
  • opt: 1
  • debug: 1
• windows11-64-2009-qr: 3
  • opt: 2
  • debug: 1
• windows11-64-2009-shippable-qr: 1
  • opt: 1
• linux1804-64-ccov-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1887331&startday=2024-03-18&endday=2024-03-24&tree=all

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1403050b0776
Fix test_search_config_v2_nimbus.js for Thunderbird. r=barret

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1403050b0776

Comment 5

[Intermittent Failures Robot]

17 failures in 742 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 17

Platform and build breakdown:

• linux1804-64-shippable-qr: 2
  • opt: 2
• linux1804-64-qr: 2
  • opt: 1
  • debug: 1
• macosx1015-64-qr: 2
  • opt: 1
  • debug: 1
• windows11-64-2009-qr: 4
  • opt: 2
  • debug: 2
• windows11-32-2009-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64-ccov-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1887331&startday=2024-03-25&endday=2024-03-25&tree=all

Comment 6

[Intermittent Failures Robot]

21 failures in 3590 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 21

Platform and build breakdown:

• linux1804-64-shippable-qr: 3
  • opt: 3
• linux1804-64-qr: 4
  • opt: 2
  • debug: 2
• macosx1015-64-qr: 2
  • opt: 1
  • debug: 1
• windows11-64-2009-qr: 4
  • opt: 2
  • debug: 2
• windows11-32-2009-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64-ccov-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 1
  • opt: 1
• windows11-32-2009-shippable-qr: 1
  • opt: 1
• windows11-64-2009-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1887331&startday=2024-03-25&endday=2024-03-31&tree=all

Comment 7

[Rob Wu [:robwu]]

The patch here causes the Normandy client to be included with Thunderbird, seemingly to fix some unit tests.

Was the introduction of the Normandy client and its associated functionality to Thunderbird intentional? To learn more about Normandy, see

• https://firefox-source-docs.mozilla.org/toolkit/components/normandy/normandy/index.html
• https://mozilla.github.io/normandy/

Comment 8

[Magnus Melin [:mkmelin]]

It's intentional, though, ideally not desired as we don't use it. Unfortunately the reality is that the cross dependencies in other areas on things which are part of Normandy will be breaking tests.

Comment 9

[Rob Wu [:robwu]]

If you don't use it, then why don't you disable the tests or fix up the implementation instead of adding Normandy? There is the AppConstants.MOZ_NORMANDY flag if you need to have conditional logic.

Adding a giant chunk of code such as Normandy, for it to be unused on Thunderbird seems risky. Tests that configure Normandy with the expectation of it to be working would be unrealistic. And because the code is included, it is not immediately obvious that the Normandy dependency is unused. Normandy is an optional component, e.g. it is not included on Android. So I would expect little pain from maintaining a Normandy-free Thunderbird.

P.S. I came across this change and was curious about the rationale; if you willingly made the change in an informed way, then by all means continue as is.

Comment 10

[Magnus Melin [:mkmelin]]

Thanks Rob,
Indeed it may after all be better to just disable the test.
The test itself is not fixable. The NormandyUtils.sys.mjs dependency is easily fixable, but, nimbus ExperimentManager.sys.mjs is using a lot from normandy and after that fixing dependencies gets a bit out of hand :(