Closed Bug 1887821 Opened 2 months ago Closed 2 months ago

c-c perma toolkit/components/normandy/test/unit/test_RecipeRunner.js after enabling normandy

Categories

(Firefox :: Normandy Client, defect)

Product:
Firefox
Component:
Normandy Client
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox126 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

(Keywords: intermittent-failure, intermittent-testcase)

Attachments

(1 file)

Bug 1887821 - Fix some normandy test assumptions about prefs. r=barret
48 bytes, text/x-phabricator-request
Details | Review

Since we enabled normandy for Thunderbird in bug 1887331, toolkit/components/normandy/test/unit/test_RecipeRunner.js is now failing.

There is also a new failure toolkit/components/search/tests/xpcshell/test_search_config_v2_nimbus.js, apparently due to missing v2 configuration - the wip patch in bug 1886828 fixes that.

Component: Search → Normandy Client
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/integration/autoland/rev/fe16814d7124
Fix some normandy test assumptions about prefs. r=barret

Normandy is not useful without these preferences set. Judging by the bug and the changes in this patch, it looks like the better course of action (instead of accepting Normandy without prefs) is to undo bundling Normandy: https://bugzilla.mozilla.org/show_bug.cgi?id=1887331#c7

If that advice is followed, then the patch here can be reverted to make sure that there is a loud runtime error when the Normandy prefs aren't set.

https://hg.mozilla.org/mozilla-central/rev/fe16814d7124

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: