1887744 - `moz-phab submit` should not clear the summary on update

Status: NEW

(Conduit :: moz-phab, defect)

Description

[Andrew Erickson [:aerickson]]

moz-phab version (from moz-phab --version): MozPhab 1.5.1 (Python 3.12.2, Darwin)
Python version (from python3 --version): Python 3.12.2
OS:

ProductName:		macOS
ProductVersion:		13.6.4
BuildVersion:		22G513

---

Whenever I update a diff/review with moz-phab (after submitting via moz-phab initially, doing a git commit --amend, and then run moz-phab) the summary field of my diff gets cleared out. It's super annoying because then I have to go back in and replace it with my previous summary (pulled from history... nice that's there).

I didn't see any option regarding this.

moz-phab should at least check to see if it's empty if it's trying to put something in the summary field. Is that what it's doing?

Would if not is_update: before https://github.com/mozilla-conduit/review/blob/f9822ac3a7a2c51eb965b90f89aa701353eeefeb/mozphab/commands/submit.py#L622 do the trick? Happy to make a PR.

Thanks!

Comment 1

[Andrew Erickson [:aerickson]]

I never get any content in the summary when I submit a new phab (it sounds like it should have the commit info in it?) ... is the functionality broken?

I get the desire to put commit info in the summary... are we open to improving this feature to somehow append the commit info to existing content (so user input into the summary on the web doesn't get wiped out when updating)?

I've started putting all of my 'Summary' info into 'Test Plan' since it doesn't get wiped out on update.