188795 - missing error page descriptions

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Peter Henderson]

Bug 156997 fixed the error pages to be rendered with nice XHTML and a CSS
stylesheet. One minor error that the review missed is that dnsNotFound is
included twice. It does not get displayed twice, but it is included in the
source XHTML twice. It is an error for two elements to have the same id.

Actual results:
chrome://global/content/netError.xhtml does not validate because it contains
both a duplicate <div> with the id et_dnsNotFound and another pair of <div>s
with the id ld_dnsNotFound.

Solution:
Remove the second et_dnsNotFound and ld_dnsNotFound.

Comment 1

[Peter Henderson]

Attachment: Patch v1

removes the second <div> from each place it's duplicated

Comment 2

[Adam Lock]

Thanks for catching this, however I think the duplicate dnsNotFound should
actually be a netReset instead which is listed in the DTD but has no entry in
the XHTML. Can you update your patch?

Comment 3

[Peter Henderson]

Attachment: Patch v2 (checked in)

Fixes it as Adam said, but I looked up the docshell code that assigns the error
message names:
http://lxr.mozilla.org/seamonkey/source/docshell/base/nsDocShell.cpp#2472
and there are still a bunch missing, one of which I hit yesterday
(netInterrupt). Also, they are in a different order; we might want to be
consistent, although it doesn't matter.

The ones missing are:
- netInterrupt
- unknownSocketType (Doc failed to load because PSM is not installed)
- isprinting (Doc navigation attempted while Printing or Print Preview)
- deniedPortAccess (Port blocked for security reasons)
- proxyResolveFailure (Proxy hostname could not be resolved.)
- proxyConnectFailure (Proxy connection was refused.)

I don't think we should have an error page for isprinting since the error is
that navigation was attempted, and loading the page would be more navigation. I
haven't encountered any of the others, but I think they should probably be
included for completeness. If someone could write nice descriptions, I can make
another patch.

Comment 4

[Adam Lock]

Comment on attachment 111399 [details] [diff] [review]
Patch v2 (checked in)

r=adamlock

Comment 5

[Adam Lock]

I've checked in this patch for you. I'll keep the bug open and rename it to
cover the other missing entries.

Comment 6

[Peter Henderson]

So, the other descriptions are still missing. There are short descriptions from
the dialog box error messages in appstrings.properties
http://lxr.mozilla.org/seamonkey/source/docshell/resources/locale/en-US/appstrings.properties

I can add those to the XHTML page but I don't know what to use for the long
descriptions. Adam, I believe you wrote or at least compiled the existing error
descriptions. Up for writing some more?

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: add more messages

This patch adds descriptions for netInterrupt, deniedPortAccess,
proxyResolveFailure, and proxyConnectFailure.  I don't know what the actual
long description text should be for the proxy cases, so with this patch, the
proxy pages display the same error text twice.

(sorry for all the bugspam)

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Remaining issues will be handled in bug 301208.

Marking this one as FIXED now.