1887998 - Have mozperftest and raptor use the same browsertime version

Status: RESOLVED FIXED

(Testing :: Performance, enhancement, P1)

Description

[Kash Shampur [:kshampur] ⌚EST]

Now that we have node-18 toolchain, we can upgrade to a more recent browsertime (bug 1878786)

After that/in parallel, It would be a good idea to begin looking at having mozperftest and raptor in sync, and we should do this by having both harnesses sharing the same installation

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

rough example attempt at this https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=b0d22c79b68e9fef892e8c7ab8b0214474394054&selectedTaskRun=eyqRd_foSjmIYq2_9h4U8g.0

added the browsertime as a toolchain to the perftest record task. So this task is using the same browsertime version as raptor, by sharing the same toolchain task

sort of works (see the amazon screenshot). works locally, will look into the failures in CI

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

Looks like there is an issue with the browsertime commands.screenshot.take on the Linux in CI with the latest browsertime (works fine locally on my mac).

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

issue is the jimp dependency. At some point it was made optional, and seems like it does not install on linux. By adding it as a devdependency in our package.json it seems to run and give screenshots

Comment 4

[Kash Shampur [:kshampur] ⌚EST]

(In reply to Kash Shampur [:kshampur] ⌚EST from comment #3)

issue is the jimp dependency. At some point it was made optional, and seems like it does not install on linux. By adding it as a devdependency in our package.json it seems to run and give screenshots

example working now: https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=4f9b17d1db2b6e95c385f384712a2140cc8e13e5&selectedTaskRun=fCS0pjC7Tee3CatRjzQvtg.0

so that fixes record task, need to look into the remaining mozperftests that use browsertime

Comment 5

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1887998 - Have mozperftest and raptor use the same browsertime. r?#perftest

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8d70625755a
Have mozperftest and raptor use the same browsertime. r=perftest-reviewers,sparky

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a8d70625755a