1888238 - [wmfme] do not block main thread when querying the capabilites from MFCDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

Currently this blocks the main thread and causes jank, which can be observed in bug 1885761. We should make it async.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1888238 - part1 : refactor 'KeySystemConfig::CreateKeySystemConfigs' for the preparation of making it return an async result.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1888238 - part2 : make ipdl method 'GetCapabilities()' independent with the MFCDM's key system.

In following patches, we will make the method be able to get
capabilities from all different key systems. This is a
pre-requirement refactoring.

Depends on D205888

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1888238 - part3 : create a helper class WMFCDMCapabilities to get capabilities asynchronously.

In following patches, we will use this new method to replace
WMFCDMImpl::GetCapabilities().

Depends on D205889

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1888238 - part4 : move the deprecation function to EMEUtils.

Depends on D205890

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1888238 - part5 : let MediaKeySystemAccessRequest have its own DecoderDoctorDiagnostics to track its error status.

A pre-requirement for making the process of getting capabilities async.

Depends on D205891

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1888238 - part6 : make the process of getting capabilities async.

Depends on D205892

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9fb675bbb91
part1 : refactor 'KeySystemConfig::CreateKeySystemConfigs' for the preparation of making it return an async result. r=jolin
https://hg.mozilla.org/integration/autoland/rev/13100b02973d
part2 : make ipdl method 'GetCapabilities()' independent with the MFCDM's key system. r=jolin
https://hg.mozilla.org/integration/autoland/rev/309a46bb6661
part3 : create a helper class WMFCDMCapabilities to get capabilities asynchronously. r=jolin
https://hg.mozilla.org/integration/autoland/rev/f09c80138d87
part4 : move the deprecation function to EMEUtils. r=jolin
https://hg.mozilla.org/integration/autoland/rev/883227d7d946
part5 : let MediaKeySystemAccessRequest have its own DecoderDoctorDiagnostics to track its error status. r=jolin
https://hg.mozilla.org/integration/autoland/rev/d6168bc7f850
part6 : make the process of getting capabilities async. r=jolin

Comment 8

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h(48,37): error: member access into incomplete type 'mozilla::dom::Document'

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd0736005507
part1 : refactor 'KeySystemConfig::CreateKeySystemConfigs' for the preparation of making it return an async result. r=jolin
https://hg.mozilla.org/integration/autoland/rev/a84302936d3b
part2 : make ipdl method 'GetCapabilities()' independent with the MFCDM's key system. r=jolin
https://hg.mozilla.org/integration/autoland/rev/35a1aec85be3
part3 : create a helper class WMFCDMCapabilities to get capabilities asynchronously. r=jolin
https://hg.mozilla.org/integration/autoland/rev/9cc9b13f154e
part4 : move the deprecation function to EMEUtils. r=jolin
https://hg.mozilla.org/integration/autoland/rev/70185eb16e5b
part5 : let MediaKeySystemAccessRequest have its own DecoderDoctorDiagnostics to track its error status. r=jolin
https://hg.mozilla.org/integration/autoland/rev/604ab60e8bee
part6 : make the process of getting capabilities async. r=jolin

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/bd0736005507
https://hg.mozilla.org/mozilla-central/rev/a84302936d3b
https://hg.mozilla.org/mozilla-central/rev/35a1aec85be3
https://hg.mozilla.org/mozilla-central/rev/9cc9b13f154e
https://hg.mozilla.org/mozilla-central/rev/70185eb16e5b
https://hg.mozilla.org/mozilla-central/rev/604ab60e8bee