1888569 - Clean up unused C++ headers

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Sean Burke [:leftmostcat]]

Our C++ code is chock-full of includes of headers which are either overly broad or entirely unused. This clutters up linting and can come back to bite us if a header—even one we're not using—is removed. These should be removed where possible and replaced with narrower imports where necessary.

Comment 1

[Sean Burke [:leftmostcat]]

Attachment: Bug 1888569 - Clean up unused headers from IMAP. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/48823f8fa933
Clean up unused headers from IMAP. r=kaie

Comment 3

[Sean Burke [:leftmostcat]]

Attachment: Bug 1888569 - Only include headers as needed. r=#thunderbird-reviewers

Comment 4

[Sean Burke [:leftmostcat]]

Attachment: Bug 1888569 - Only include headers as needed. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e2aa6040155b
Only include headers as needed. r=darktrojan

Comment 6

[Kai Engert [:KaiE:]]

While removing include files from mimei.cpp, there were also helpful comments removed, which indicated an inheritance structure,
see https://hg.mozilla.org/comm-central/rev/e2aa6040155b#l254.1

I'd like to restore those comments.

Comment 7

[Kai Engert [:KaiE:]]

Attachment: Bug 1888569 - Add comments to restore MIME inheritance documentation. r=leftmostcat

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84b0db260544
Add comments to restore MIME inheritance documentation. r=leftmostcat