1888978 - Crash in [@ java.lang.IllegalStateException: at android.os.Parcel.createExceptionOrNull(Parcel.java)]

Status: RESOLVED FIXED

(GeckoView :: PDF Viewer, defect, P1)

Description

[Cathy Lu [:calu]]

Crash report: https://crash-stats.mozilla.org/report/index/4afbc268-4fd7-4330-a166-cfe7e0240401

Java stack trace:

java.lang.IllegalStateException
	at android.os.Parcel.createExceptionOrNull(Parcel.java:2394)
	at android.os.Parcel.createException(Parcel.java:2370)
	at android.os.Parcel.readException(Parcel.java:2353)
	at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:190)
	at android.database.DatabaseUtils.readExceptionWithFileNotFoundExceptionFromParcel(DatabaseUtils.java:153)
	at android.content.ContentProviderProxy.openTypedAssetFile(ContentProviderNative.java:781)
	at android.content.ContentResolver.openTypedAssetFileDescriptor(ContentResolver.java:1993)
	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1808)
	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1724)
	at org.mozilla.geckoview.ContentInputStream.isReadable(ContentInputStream.java:38)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:615)

Comment 1

[Cathy Lu [:calu]]

Hey Calixte, does this crash look familiar to you?
Looks like it interacts with GeckoViewContentChannel.OpenContentStream calling ContentInputStream.isReadable: https://searchfox.org/mozilla-central/rev/10f46c9c638e0e5935ed9fa12aadc9d0d4e71ade/mobile/android/components/geckoview/GeckoViewContentChannel.cpp#30
Any idea why it might be causing a createExceptionOrNull crash?

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1815739

Comment 3

[Cathy Lu [:calu]]

Is this related to or fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1881927?

Comment 4

[Calixte Denizet (:calixte)]

:calu, it's very likely unrelated and it isn't fixed by the mentioned patch.
According to the docs:
https://developer.android.com/reference/android/content/ContentResolver#openAssetFileDescriptor(android.net.Uri,%20java.lang.String)
openAssetFileDescriptor is supposed to throw a FileNotFoundException which is caught under IOException.
I'd say that the content provider (which is an other app) is failing to provide the queried file.
So an easy fix would be to just catch IllegalStateException:
https://searchfox.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/ContentInputStream.java#149
:olivia, what do you think about adding IllegalStateException to list of the potential exception types ? or about just catching Exception to avoid any other future issues ?

Comment 5

[Olivia Hall [:olivia]]

Thanks for looking into this!

:olivia, what do you think about adding IllegalStateException to list of the potential exception types ? or about just catching Exception to avoid any other future issues ?

I like both ideas! Just catching Exception seems reasonable to me, since it seems like there is a lot of potentially different exceptions and we don't have any branching behavior based on exception.

Comment 6

[Cathy Lu [:calu]]

Attachment: Bug 1888978 - Catch exceptions for PDF Viewer openAssetFileDescriptor

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69ec5a7efc4d
Catch exceptions for PDF Viewer openAssetFileDescriptor r=geckoview-reviewers,ohall,calixte

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/69ec5a7efc4d

Comment 9

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:calu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Cathy Lu [:calu]]

This is fine to let it to go to nightly.