1889116 - Search icon is not updated according to selected option

Status: VERIFIED FIXED

(Fenix :: Search, defect)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: issue1.mp4

Prerequisites

• Use a fresh profile.

Steps to reproduce

1. On the homescreen, tap the search engine icon drop-down menu.
   2.a) Select Tabs/Bookmarks/ History search engine.
   3.a) Observe the selected search icon from the search bar.

2.b) Select Bing/Amazon/DuckDuckGo/eBay/Wikipedia engine.
3.b) Observe the selected search icon from the search bar.

Expected behavior

The search icon is successfully updated according to the selected search engine.

Actual behavior

a) There is no icon displayed when selecting one of the Tabs/Bookmarks/History option. (reproducible only in dark mode)
b) The first selected search icon remains displayed for all the next selected engines.

Device information

• Firefox version: Firefox Nightly 126 (2024-04-02)
• Android device model: Samsung A32 (Android 13) , Oppo A15s (Android 10), Xiaomi mi8 lite (Android 10)

Any additional information?

• This issue is a recent regression: Last good build (2024-04-01) - First Bad Build (2024-04-02)

Comment 1

[Vasilica Tamas QA [:vtamas]]

Attachment: issue2.mp4

Comment 2

[Donal Meehan [:dmeehan]]

Bug 1885565 stands out as a possible regressor from the list of bugs landed between 2024-04-01 and 2024-04-02

:gl could you take a look? Please adjust the regressor if it's something else.
Tracking for Fx126 in the meantime.

Comment 3

[Roger Yang [:royang]]

From the video it does look like the search engine is switching but the icon is not updating. I can see that in one instance the QR reader button shows up and then when we switch again, it goes away. That means the underlying search engine is updating to the taps.

Comment 4

[[:skhan]]

The issue is a regressor from Bug 1883419 and I will be taking a look on how to fix this.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:gl, since you are the author of the regressor, bug 1885565, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[[:skhan]]

Attachment: Bug 1889116 - Fix search icon not updated issue

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4068d7c5176f
Fix search icon not updated issue r=android-reviewers,Roger

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/4068d7c5176f

Comment 9

[Vasilica Tamas QA [:vtamas]]

Attachment: az_recorder_20240408_160812.mp4

This issue is verified as fixed on Firefox Nightly 126 (2024-04-08) on Samsung A32 (Android 13), Oppo Find X3 Neo (Android 11), Xiaomi 12T (Android 12). The search icon is correctly updated according to the selected search engine.