Closed Bug 1885565 Opened 1 year ago Closed 1 year ago

[Menu Redesign] Implement skeleton bottom sheet menu

Categories

(Firefox for Android :: Toolbar, task, P3)

Product:
Firefox for Android
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: royang, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(4 files, 4 obsolete files)

Bug 1885565 - Part 1: Add mozac_ic_avatar_circle_24 to ui-icons
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885565 - Part 3: Add border secondary color token
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885565 - Part 2: Fix up parameter ordering and kDoc descriptions in NavigationBar
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885565 - Part 4: Implement skeleton bottom sheet menu
48 bytes, text/x-phabricator-request
Details | Review

Please take a look at the current translations bottom sheet as an example

Summary: Implement skeleton bottom sheet menu → [Menu Redesign] Implement skeleton bottom sheet menu
Blocks: menu-redesign
Depends on: 1885564
Blocks: 1885566
Blocks: 1885578
Blocks: 1885580
Blocks: 1885581
Blocks: 1885582
Whiteboard: [fxdroid]
Severity: -- → S2
Severity: S2 → S3
Severity: S3 → N/A
Depends on: 1886812
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #9394185 - Attachment is obsolete: true
Attachment #9394186 - Attachment is obsolete: true
Keywords: leave-open

Comment on attachment 9394200 [details]
Bug 1885565 - Part 3: Add a MenuGroup component for the menu redesign

Revision D206219 was moved to bug 1885580. Setting attachment 9394200 [details] to obsolete.

Attachment #9394200 - Attachment is obsolete: true
Attachment #9394201 - Attachment description: Bug 1885565 - Part 4: Fix up parameter ordering and kDoc descriptions in NavigationBar → Bug 1885565 - Part 3: Fix up parameter ordering and kDoc descriptions in NavigationBar
Attachment #9394202 - Attachment description: Bug 1885565 - Part 5: Add strings for the sign in header in the menu redesign → Bug 1885565 - Part 4: Add strings for the sign in header in the menu redesign

Comment on attachment 9394202 [details]
Bug 1885565 - Part 4: Add strings for the sign in header in the menu redesign

Revision D206221 was moved to bug 1885602. Setting attachment 9394202 [details] to obsolete.

Attachment #9394202 - Attachment is obsolete: true
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2626f8021a05 Part 1: Add mozac_ic_avatar_circle_24 to ui-icons r=android-reviewers,Roger
Attachment #9394201 - Attachment description: Bug 1885565 - Part 3: Fix up parameter ordering and kDoc descriptions in NavigationBar → Bug 1885565 - Part 2: Fix up parameter ordering and kDoc descriptions in NavigationBar
Attachment #9394188 - Attachment description: Bug 1885565 - Part 2: Add border secondary color token → Bug 1885565 - Part 3: Add border secondary color token
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27b39ad19b02 Part 2: Fix up parameter ordering and kDoc descriptions in NavigationBar r=android-reviewers,Roger

Backed out for causing fenix lint failure

Backout link

Push with failures

Failure log

Flags: needinfo?(gl)
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7ec5d35ae0d Part 2: Fix up parameter ordering and kDoc descriptions in NavigationBar r=android-reviewers,Roger
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0565764a1c9a Part 3: Add border secondary color token r=android-reviewers,007
Flags: needinfo?(gl)
Regressions: 1889116
No longer regressions: 1889116
Flags: qe-verify-
Keywords: leave-open
Attachment #9395303 - Attachment description: Bug 1885565 - [Menu Redesign] Implement skeleton bottom sheet menu → Bug 1885565 - Part 4: Implement skeleton bottom sheet menu
Attachment #9395303 - Attachment description: Bug 1885565 - Part 4: Implement skeleton bottom sheet menu → WIP: Bug 1885565 - Part 4: Implement skeleton bottom sheet menu
Attachment #9395303 - Attachment description: WIP: Bug 1885565 - Part 4: Implement skeleton bottom sheet menu → Bug 1885565 - Part 4: Implement skeleton bottom sheet menu
Attachment #9395303 - Attachment description: Bug 1885565 - Part 4: Implement skeleton bottom sheet menu → WIP: Bug 1885565 - Part 4: Implement skeleton bottom sheet menu
Attachment #9395303 - Attachment description: WIP: Bug 1885565 - Part 4: Implement skeleton bottom sheet menu → Bug 1885565 - Part 4: Implement skeleton bottom sheet menu
Blocks: 1890796
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65f9780614f7 Part 4: Implement skeleton bottom sheet menu r=android-reviewers,007

https://hg.mozilla.org/mozilla-central/rev/65f9780614f7

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
No longer depends on: 1885564
No longer depends on: 1886812
No longer blocks: menu-redesign
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: