1889200 - bin/sentry-wrap.py doesn't specify a release

Status: RESOLVED FIXED

(Tecken :: General, defect, P3)

Description

[Daniel Thorn [:relud]]

the sentry event in bug 1873752 could theoretically be "resolved in next release", but we can't use that because bin/sentry-wrap.py doesn't specify a release.

this is where we're setting release when using fillmore: https://github.com/mozilla-services/tecken/blob/b4e6880c239261bb33dcbb1243a9711cb79bcbd3/tecken/apps.py#L67-L83

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

DOH! Also, sentry-wrap.py is another utility that I think I copy around to most of the service repositories.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Some thoughts: This script runs and then launches another process with subprocess, so it's not privy to what's in the Python process memory and we don't need to worry about what data is getting sent in the event. Thus we don't need fillmore here. We could switch it to use fillmore if we wanted to, but we don't need it.

I think we can import some functions from tecken/libdockerflow.py and then use that to set the release argument in sentry_sdk.init and that'll fix this.

Comment 3

[Bianca Danforth [:bdanforth]]

Attachment: [mozilla-services/tecken] bug-1889200: specify release in sentry-wrap.py (#2917)

Comment 4

[Bianca Danforth [:bdanforth]]

biancadanforth merged PR [mozilla-services/tecken]: bug-1889200: specify release in sentry-wrap.py (#2917) in 3af5977.

Comment 5

[Bianca Danforth [:bdanforth]]

This was deployed in bug #1893447 tag v2024.04.25.

Comment 6

[Bianca Danforth [:bdanforth]]

To verify this patch in prod, I'd need to log into the AWS console, open a shell in the web container and run ./bin/sentry_wrap.py test-sentry. Since I don't have access to the AWS console (we're in the process of migrating to GCP), willkg has kindly offered to verify this on my behalf. Swapping the needinfo to him.

Comment 7

[Bianca Danforth [:bdanforth]]

I have verified that the release field is now populated for the latest event from May 3rd, 2024 for the reference error, which recurred: https://mozilla.sentry.io/issues/4723701783/events/?project=6700123 . Closing this ticket.