1889322 - list archive button fails to open corrupted archive url sent by google groups

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Landry Breuil (:gaston)]

testing bug #512385 on 125.0b3, on a mail with that header (google sends corrupted headers ??):

List-Archive: <https://groups.google.com/group/georchestra-dev

i get this (valid) error in the browser console:

Uncaught Error: PageInfo: Invalid value for property 'url': "%3Chttps://groups.google.com/group/georchestra-dev"
    validateItemProperties resource://gre/modules/PlacesUtils.sys.mjs:783
    validatePageInfo resource://gre/modules/PlacesUtils.sys.mjs:1176
    insert resource://gre/modules/History.sys.mjs:252
    openUILink resource:///modules/LinkHelper.sys.mjs:60
    openListURL chrome://messenger/content/msgHdrView.js:3259
    oncommand about:message:1

i dunno if i'm the only one getting such corrupted headers from google groups.. it works fine for mails sent by github, ie the archive header is valid:

List-Archive: https://github.com/georchestra/georchestra

should the code handle such broken urls, or someone should poke google to fix their thing ?

Comment 1

[Magnus Melin [:mkmelin]]

In general google groups seems to send proper header. If there are cases where it's not, it would be good to alert google about it.
I wonder if it's really been sent corrupted, or if a server on the way could have corrupted it?
Or, if you look at the mail source (Ctrl+U), is there folding whitespace and here actually is a '>' somewhere on the next line?

Note that while the github List-Archive header is working, it's not quite correct: per rfc 2369:

The contents of the list header fields mostly consist of angle- bracket ('<', '>') enclosed URLs.

Comment 2

[Magnus Melin [:mkmelin]]

(The related bug is bug 29041, bug 512385 is specifically about single message permaurl. List-Archive is the list archives main url.)

Comment 3

[Hartmut Welpmann [:welpy-cw]]

I noticed this yesterday as well, excerpt from the message source:

List-Archive: <https://groups.google.com/group/testgroup202404
List-Unsubscribe: <mailto:[e-mail]>, <https://groups.google.com/group/testgroup202404/subscribe>

Apparently this bug has been around for quite some time, see https://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=3563#c0 ...

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1889322 - Handle google groups sometimes having incorrectly formatted List-Archive header. r=#thunderbird-reviewers

Handle list archive header without trailing angle bracket like List-Archive: <https://groups.google.com/group/testgroup202404

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b189586735e1
Handle google groups sometimes having incorrectly formatted List-Archive header. r=vineet