1889333 - [toolbar redesign] The cursor is not displayed in the search bar after performing a voice search

Status: NEW

(Firefox for Android :: Search, enhancement, P3)

Description

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: az_recorder_20240403_113137.mp4

Steps to reproduce

1. Install and launch Firefox for Android.
2. Focus the search bar.
3. Tap on the microphone icon.
4. Perform a voice search.

Expected behavior

The cursor is successfully displayed at the end of the search term.

Actual behavior

The cursor is not displayed in the search bar.

Device information

• Firefox version: Firefox Nightly 126 (2024-04-02) and Firefox 125 Beta 7
• Android device model: Oppo Find X3 Neo (Android 10), Samsung A32 (Android 13)

Any additional information?

I suspect this issue was regressed by Bug 1880284

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:royang, since you are the author of the regressor, bug 1880284, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Roger Yang [:royang]]

This is not an regression. Current toolbar is also behaving this way. The keyboard goes away after completing voice search. I think this is a question on do we want this as an requirement

Comment 3

[Roger Yang [:royang]]

Attachment: Screen_recording_20240403_102454.webm

Comment 4

[Roger Yang [:royang]]

Attachment: Screen_recording_20240403_102800.mp4

Comment 5

[Roger Yang [:royang]]

:aarjav, do you think this is something that we want to have? If so, do we want to modify it for both current toolbar and the redesigned toolbar? Thanks

Comment 6

[Aarjav [:aarjav]]

:royang, Hey, it would be better to display the cursor in the new and the current toolbar after the user has used the voice search feature.
Showing the cursor would be better because the user would know that they can just start typing/editing if there is something wrong that was picked up by voice or they might want to add something to the search query.

Comment 7

[Roger Yang [:royang]]

Sounds good, I'll update this and move this into part of the finishing work for toolbar redesign. Thanks

Comment 8

[Roger Yang [:royang]]

This should be done for both current toolbar and redesigned toolbar

Comment 9

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Release blockers to priority P3 until we finish fixing our Beta experiment blockers.

Comment 10

[Joe M [:jmahon]]

• As described in comment 6, we do want to stay in the "edit" state after a voice search. This should be done for both the current and redesigned toolbar experiences.

Comment 11

[Joe M [:jmahon]]

Refinement notes:

• When pointing, we realized there's a few related issues:
  • When you use voice-to-text, the toolbar stays in "display" mode (should be in edit mode)
  • When you use voice-to-text from within an active tab, it also appends to the current page's URL instead of overwriting the search box with what you said (that could probably be opened as a separate bug, if the person who works on this would like to split it off)

Also - this bug is true for the existing Toolbar. Given that, I'm going to remove it from the release blockers with the assumption that we'll fix it in a later version of the new toolbar. There's not really a need to fix it in the old toolbar.