188956 - Clean up Cache pref panel.

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Suresh]

There are few things that needs to be cleaned/removed from Cache pref panel.

Darin: What are the items that needs to be cleaned? Couple of them you mentioned
to me are, (correct me if i'm wrong)
1. Removing Memory Cache from the panel.
2. Replace KB with MB.

Thanks!

Comment 1

[Darin Fisher]

1- probably, although if folks object then we should at least have only one
"clear cache" button.

2- yes.

3- also, try to widen the cache directory entry box if possible.

Comment 2

[Suresh]

Attachment: test screenshot

This attachment is just the initial work...I'll talk to Patrice about her
opinion. Adding pre-fetching pref to Cache panel is still an issue :(

Comment 3

[Cathleen]

how about change the text to "Cache", instead of "Disk Cache"

    Cache:  50000kb        [ Clear Cache ]

what do people think?


I also agree that prefetching option makes this panel to crowded.  I like the
screen shot in bug 166648 better, under the http networking panel.

Comment 4

[Darin Fisher]

yeah, let's eliminate the word "Disk" throughout.

as for the prefetching pref, the HTTP Networking panel makes sense assuming
prefetching only applies to HTTP content which is currently the case, but...
dougt mentioned wanting to possibly prefetch other things like FTP directory
listings.  prefetching doesn't inheritantly have anything to do with HTTP.

Comment 5

[Hermann Schwab]

If memory cache is removed from panel, how can it be limited, so Mozilla doesn´t
take all available ram for cache?
iirc I saw some people complaining about Opera7 taking all of ram, but I´m not
sure about this.

Comment 6

[Darin Fisher]

Hermann:

mozilla has a memory cache limit of 4MB.  it is not meant to be modified. 
except.. in the future, mozilla will likely have a memory cache size that is
more proportional to the amount of available RAM.  though don't expect it to
ever be very large.  advanced users can still adjust the memory cache size
manually by editing prefs.js.

suresh: isn't this bug fixed now that bug 166648 has been fixed?

Comment 7

[Suresh]

darin: There is one more task to be fixed in this bug - change KB to MB. 

Comment 8

[Suresh]

Attachment: patch to convert KB to MB.

Comment 9

[gordon]

I don't think we can change the semantics of this pref from kilobytes to
megabytes without migrating existing pref settings.  If a user has changed this
setting, and new browsers interpret it as Mb rather than kb, that might be bad.

Comment 10

[Suresh]

gordon/darin: any thoughts on how to migrate the existing user setting from KB
to MB? 

thanks!

Comment 11

[Darin Fisher]

Comment on attachment 113537 [details] [diff] [review]
patch to convert KB to MB.

hmm... the actual meaning of the pref strings in all.js should not change. 
only the UI should change.  if you change the meaning of a pref string then you
will have to add code to migrate existing users profiles.

Comment 12

[Darin Fisher]

suresh: sorry, missed the last two comments.  just change the UI, not the
preferences backend.  i know this complicates the prefs XUL code a bit, but it
is far superior to any profile migration headache.

Comment 13

[Suresh]

Attachment: updated patch

1. This patch just converts KB to MB on loading the cache panel and converts
back to KB while saving the pref.

2. I changed 50000 to 51200 KB, which is exactly 50 MB ;-) Users who have
modified the Cache value before, should still work fine.

3. Thanks to Neil for his help here!

Comment 14

[[e-mail]]

Comment on attachment 113704 [details] [diff] [review]
updated patch

I think you missed a bit from this patch :-(
Also, do you have any idea why unix.js has its own copy of the pref?

Comment 15

[Suresh]

Attachment: updated patch

Comment 16

[Matthias Versen [:Matti]]

*** Bug 198912 has been marked as a duplicate of this bug. ***

Comment 17

[Jan Varga [:janv]]

Comment on attachment 118307 [details] [diff] [review]
updated patch

r=varga

Comment 18

[Alec Flett]

Comment on attachment 118307 [details] [diff] [review]
updated patch

+    function GetFields(pageData) {
+      pageData.browserCacheDiskCache.value <<= 10;
+      return null;

You need a comment on the signifigance of the <<=10   (i.e. because the cache
is in kilobytes, and the UI is in megabytes)


other than that, looks good. sr=alecf

Comment 19

[Suresh]

moving to mozilla 1.4beta.

Comment 20

[Pham]

What about CACHE FOLDER? Does anybody in here use that? I don't see the point
and would like for that to be removed from Mozilla too.

Comment 21

[Matthias Versen [:Matti]]

a few user need this to set this to another location if the whole profile is
stored on the network.

Comment 22

[Pham]

never mind then

Comment 23

[Suresh]

fixed in trunk.

Comment 24

[Adam Guthrie]

*** Bug 299510 has been marked as a duplicate of this bug. ***