166648 - Prefs: link prefetching UI for (network.prefetch-next)

Status: RESOLVED FIXED

(Core :: Networking, defect, P4)

Description

[Darin Fisher]

allow link prefetching to be disabled via user prefs.  currently, there is only
a static pref in all.js that can be set to false to disable prefetching.  this
should probably be a user pref instead.  that would give users as well as
embedders much easier control over whether or not prefetching is enabled.

Comment 1

[Hanspeter Niederstrasser]

Please make this bug block Bug 121324 [Tracking bug for ANY changes to prefs
(additions, deletions, change in usage)].  Thanks.

Comment 2

[Judson Valeski]

this is an app level UI issue rather than a core Gecko pref handling issue.
please renominiate topembed if mistaken.

Comment 3

[Darin Fisher]

jud: actually, the current preference is not fully dynamic.  so there would be a
tiny bit of backend work required to support a UI level pref.  i'll renominate
if fixing this bug ever becomes a real requirement.

-> future

Comment 4

[Darin Fisher]

-> 1.2 final as there appears to be a good number of requests for this UI
following the release of mozilla 1.2 beta.

Comment 5

[Darin Fisher]

Attachment: v1 patch

ok, this patch adds UI for the link prefetching pref to the Advanced tab.

Comment 6

[Darin Fisher]

Attachment: screenshot

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 104006 [details] [diff] [review]
v1 patch

i would change to pref to something like:

network.prefetch-next.enable

r=dougt

Comment 8

[Darin Fisher]

-> 1.3 alpha

Comment 9

[jag (Peter Annema)]

I'm not sure if the main Advanced panel is the best place for it. What about Cache?

Patrice, what do you think?

Comment 10

[jag (Peter Annema)]

Oops, forgot to CC Patrice.

Patrice, see my previous comment.

Comment 11

[Darin Fisher]

i thought about advanced:cache too, but it is already fairly crowded.  however,
we have been meaning to clean up the advanced:cache preferences panel
(specifically, to remove the memory cache size setting).  perhaps this bug needs
to be blocked by that bug :-/

Comment 12

[Cathleen]

--> suresh

Comment 13

[patrice caire]

Jag and I are checking this and it seems to us that the best place is indeed the
Advanced Cache panel. What's the bug number for cleaning up that panel? 

Comment 14

[Suresh]

I've filed a new bug 188956 to cover cache cleanup issue. Even after we clean up
Cache panel, i'm not sure the real-estate is sufficient enough in that Panel.

How about we move prefetching pref to "HTTP Networking" pref panel?

Comment 15

[Suresh]

Attachment: screenshot of pre-fetch pref in HTTP Networking panel.

Comment 16

[Suresh]

Attachment: updated Cache pref panel.

This screenshot includes,
1. Removing memory cache info.
2. Adding pre-fetching pref to Cache panel.

To Do:
Replace KB with MB. (Bug 188956 will takes care of this)


How does this screenshot looks?

Comment 17

[Suresh]

Attachment: patch

I'm hoping that this would fit on mac. If not, I'll seek Jatin's help to
rephrase the pre-fetching description in the pref panel.

Comment 18

[Suresh]

Comment on attachment 112225 [details] [diff] [review]
patch

carrying over dougt's previous review.

Comment 19

[Suresh]

Attachment: updated cache pref panel.

This screenshot includes rephrasing the pre-fetching description suggested by
Jatin. 

And this also fits well on Mac and Linux.

Comment 20

[Alec Flett]

Comment on attachment 112225 [details] [diff] [review]
patch

Why the changes to switch AddProgressListener() from the progress object to the
doc loader service? is that supposed to be part of this patch?
sr=alecf if it is, but I'd like to see documentation in the patch and/or bug to
explain

Comment 21

[Darin Fisher]

alecf: look closely.  no change.  i just moved the AddProgress call into a
helper function.  the prefetch service has always been a listener of the doc
loader service.

Comment 22

[Asa Dotzler [:asa]]

Comment on attachment 112225 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.3beta

Comment 23

[Suresh]

Fixed in trunk!

Comment 24

[[e-mail]]

Comment on attachment 112225 [details] [diff] [review]
patch

grammar check: switch "faster" and "quicker" in the messages actually checked
in :-P

Comment 25

[Sergey Sokoloff]

In the dialog (captured in
http://bugzilla.mozilla.org/attachment.cgi?id=112313&action=view attachment) the
checkbox should actually be aligned to the *top* of "Prefetch web pages [...]
can load faster" text, instead of being align to the *middle* of it.

Comment 26

[[e-mail]]

Sergey, that's a theme issue.

But the <hbox> shouldn't have flex="1", so I've filed bug 191282.

Comment 27

[benc]

VERIFIED: Mozilla 1.4b, Mach-O.

Preferences | Advanced | Cache:
Link Prefetching
[x] Prefetch web pages when idle, so that links in web page desiged for
prefetching can load faster.


Note, the final pref is "network.prefetch-next", (suggestion in #7 was never taken)

I'll be updating the prefs docs and commiting the changes today:

http://www.mozilla.org/quality/networking/docs/netprefs.html