Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Prefs: link prefetching UI for (network.prefetch-next)

RESOLVED FIXED in mozilla1.3beta

Status

()

Core
Networking
P4
minor
RESOLVED FIXED
15 years ago
7 years ago

People

(Reporter: Darin Fisher, Assigned: Suresh)

Tracking

({topembed-})

Trunk
mozilla1.3beta
topembed-
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [prefetch] checklinux, checkwin)

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

15 years ago
allow link prefetching to be disabled via user prefs.  currently, there is only
a static pref in all.js that can be set to false to disable prefetching.  this
should probably be a user pref instead.  that would give users as well as
embedders much easier control over whether or not prefetching is enabled.
(Reporter)

Updated

15 years ago
Status: NEW → ASSIGNED
Keywords: mozilla1.2, topembed
Priority: -- → P3
Whiteboard: [prefetch]
Target Milestone: --- → mozilla1.2beta
Please make this bug block Bug 121324 [Tracking bug for ANY changes to prefs
(additions, deletions, change in usage)].  Thanks.
(Reporter)

Updated

15 years ago
Keywords: nsbeta1
(Reporter)

Updated

15 years ago
Severity: normal → minor
Priority: P3 → P4

Updated

15 years ago
QA Contact: benc → tever

Comment 2

15 years ago
this is an app level UI issue rather than a core Gecko pref handling issue.
please renominiate topembed if mistaken.
Keywords: topembed → topembed-
(Reporter)

Comment 3

15 years ago
jud: actually, the current preference is not fully dynamic.  so there would be a
tiny bit of backend work required to support a UI level pref.  i'll renominate
if fixing this bug ever becomes a real requirement.

-> future
Target Milestone: mozilla1.2beta → Future
(Reporter)

Comment 4

15 years ago
-> 1.2 final as there appears to be a good number of requests for this UI
following the release of mozilla 1.2 beta.
Target Milestone: Future → mozilla1.2final
(Reporter)

Comment 5

15 years ago
Created attachment 104006 [details] [diff] [review]
v1 patch

ok, this patch adds UI for the link prefetching pref to the Advanced tab.
(Reporter)

Comment 6

15 years ago
Created attachment 104009 [details]
screenshot

Comment 7

15 years ago
Comment on attachment 104006 [details] [diff] [review]
v1 patch

i would change to pref to something like:

network.prefetch-next.enable

r=dougt
Attachment #104006 - Flags: review+
(Reporter)

Comment 8

15 years ago
-> 1.3 alpha
Target Milestone: mozilla1.2final → mozilla1.3alpha
(Reporter)

Updated

15 years ago
Attachment #104006 - Flags: superreview?(jaggernaut)

Comment 9

15 years ago
I'm not sure if the main Advanced panel is the best place for it. What about Cache?

Patrice, what do you think?

Comment 10

15 years ago
Oops, forgot to CC Patrice.

Patrice, see my previous comment.
(Reporter)

Comment 11

15 years ago
i thought about advanced:cache too, but it is already fairly crowded.  however,
we have been meaning to clean up the advanced:cache preferences panel
(specifically, to remove the memory cache size setting).  perhaps this bug needs
to be blocked by that bug :-/
(Reporter)

Updated

15 years ago
Target Milestone: mozilla1.3alpha → mozilla1.3beta

Updated

15 years ago
Blocks: 121324

Comment 12

15 years ago
--> suresh
Assignee: darin → suresh
Status: ASSIGNED → NEW

Comment 13

15 years ago
Jag and I are checking this and it seems to us that the best place is indeed the
Advanced Cache panel. What's the bug number for cleaning up that panel? 
(Assignee)

Updated

15 years ago
Depends on: 188956
(Assignee)

Comment 14

15 years ago
I've filed a new bug 188956 to cover cache cleanup issue. Even after we clean up
Cache panel, i'm not sure the real-estate is sufficient enough in that Panel.

How about we move prefetching pref to "HTTP Networking" pref panel?
Status: NEW → ASSIGNED
No longer depends on: 188956
(Assignee)

Comment 15

15 years ago
Created attachment 111653 [details]
screenshot of pre-fetch pref in HTTP Networking panel.
(Assignee)

Comment 16

15 years ago
Created attachment 112222 [details]
updated Cache pref panel.

This screenshot includes,
1. Removing memory cache info.
2. Adding pre-fetching pref to Cache panel.

To Do:
Replace KB with MB. (Bug 188956 will takes care of this)


How does this screenshot looks?
(Assignee)

Comment 17

15 years ago
Created attachment 112225 [details] [diff] [review]
patch

I'm hoping that this would fit on mac. If not, I'll seek Jatin's help to
rephrase the pre-fetching description in the pref panel.
Attachment #104006 - Attachment is obsolete: true
(Assignee)

Comment 18

15 years ago
Comment on attachment 112225 [details] [diff] [review]
patch

carrying over dougt's previous review.
Attachment #112225 - Flags: superreview?(jaggernaut)
Attachment #112225 - Flags: review+
(Assignee)

Comment 19

15 years ago
Created attachment 112313 [details]
updated cache pref panel.

This screenshot includes rephrasing the pre-fetching description suggested by
Jatin. 

And this also fits well on Mac and Linux.
Attachment #104009 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #111653 - Attachment is obsolete: true
Attachment #112222 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #112225 - Flags: superreview?(jaggernaut) → superreview?(bryner)
(Assignee)

Updated

15 years ago
Attachment #112225 - Flags: superreview?(bryner) → superreview?(alecf)

Comment 20

15 years ago
Comment on attachment 112225 [details] [diff] [review]
patch

Why the changes to switch AddProgressListener() from the progress object to the
doc loader service? is that supposed to be part of this patch?
sr=alecf if it is, but I'd like to see documentation in the patch and/or bug to
explain

Updated

15 years ago
Attachment #112225 - Flags: superreview?(alecf) → superreview+
(Assignee)

Updated

15 years ago
Attachment #112225 - Flags: approval1.3b?
(Reporter)

Comment 21

15 years ago
alecf: look closely.  no change.  i just moved the AddProgress call into a
helper function.  the prefetch service has always been a listener of the doc
loader service.

Comment 22

15 years ago
Comment on attachment 112225 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.3beta
Attachment #112225 - Flags: approval1.3b? → approval1.3b+
(Assignee)

Comment 23

15 years ago
Fixed in trunk!
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 24

15 years ago
Comment on attachment 112225 [details] [diff] [review]
patch

grammar check: switch "faster" and "quicker" in the messages actually checked
in :-P
In the dialog (captured in
http://bugzilla.mozilla.org/attachment.cgi?id=112313&action=view attachment) the
checkbox should actually be aligned to the *top* of "Prefetch web pages [...]
can load faster" text, instead of being align to the *middle* of it.

Updated

15 years ago
Attachment #104006 - Flags: superreview?(jaggernaut)

Comment 26

15 years ago
Sergey, that's a theme issue.

But the <hbox> shouldn't have flex="1", so I've filed bug 191282.

Comment 27

14 years ago
VERIFIED: Mozilla 1.4b, Mach-O.

Preferences | Advanced | Cache:
Link Prefetching
[x] Prefetch web pages when idle, so that links in web page desiged for
prefetching can load faster.


Note, the final pref is "network.prefetch-next", (suggestion in #7 was never taken)

I'll be updating the prefs docs and commiting the changes today:

http://www.mozilla.org/quality/networking/docs/netprefs.html
QA Contact: tever → benc
Summary: allow link prefetching to be disabled via user prefs → Prefs: link prefetching UI for (network.prefetch-next)
Whiteboard: [prefetch] → [prefetch] checklinux, checkwin
You need to log in before you can comment on or make changes to this bug.