1889569 - `Print Frame...` and `Print Selection...` are displayed even if print.enabled is set to false

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[6k64x4ma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

1. Set print.enabled to false in about:config.
2. Right-click on a frame, or, select some text and right-click.

Actual results:

• Context menu has Print Frame... and Print Selection....
  I can print pages from these menu items.

Expected results:

• I think these menu items should be disabled or hidden.

Comment 1

[6k64x4ma]

I noticed that "Print page" and "Save page as PDF" in Quick Actions are also not disabled.

Comment 2

[Mike Kaply [:mkaply]]

Where are the Quick Actions?

Comment 3

[6k64x4ma]

Type "print" or "pdf" in the address bar. (Only enabled in EARLY_BETA_OR_EARLIER)

Comment 4

[Mike Kaply [:mkaply]]

Greg, do you want to do this or do you want me to?

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bug 1889569 - Disable more print entrypoints when print is disabled. r?gregp

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b00dabe7bbf1
https://hg.mozilla.org/integration/autoland/rev/e14fd2f22940
Disable more print entrypoints when print is disabled. r=gregp,urlbar-reviewers,adw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9dd1ac01f705
https://hg.mozilla.org/integration/autoland/rev/aa60b8bbd1f9
Revert "Bug 1889569 - Disable more print entrypoints when print is disabled. r=gregp,urlbar-reviewers,adw" for causing bc failures @ browser_policy_trackingprotection.js

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_policy_trackingprotection.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/aa60b8bbd1f943c438c39891512ad5a4b79d2ee9

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/trackingprotection/browser_policy_trackingprotection.js

Comment 9

[Mike Kaply [:mkaply]]

Amateur hour over here. I accidentally including a different patch with this one.

Fixing.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8904f18be4e3
https://hg.mozilla.org/integration/autoland/rev/50253c0af5d1
Disable more print entrypoints when print is disabled. r=gregp,urlbar-reviewers,adw

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/50253c0af5d1

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2025-08-26 Firefox Nightly build on Windows 10, using the STR from Comment 0.

Verified as fixed on Firefox Nightly 145.0a1 and Firefox 144.0b2 on Windows 10, Ubuntu 22, macOS 15.

Comment 13

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: Consistency on ESR with 140
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: low
• Explanation of risk level: Only affects if printing is disabled
• String changes made/needed: None
• Is Android affected?: no

Comment 14

[Mike Kaply [:mkaply]]

Attachment: Bug 1889569 - Disable more print entrypoints when print is disabled. r?gregp

Original Revision: https://phabricator.services.mozilla.com/D262402

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/67e202c0778e

Comment 16

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox ESR 140.4.0 on Windows 10, Ubuntu 22, macOS 15.