1989252 - Hidden actions are still visible in Quick Actions mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[6k64x4ma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:144.0) Gecko/20100101 Firefox/144.0

Steps to reproduce:

1. Set "print.enabled" to false in about:config.
2. Type "pdf" in the address bar.
   • "Save page as PDF" action is not shown. This is correct behavior.
3. Press ESC key twice and type "> " to activate Quick Actions mode.

Actual results:

"Save page as PDF" and "Print page" are visible when activating Quick Actions mode.

Expected results:

These items should be hidden when print.enabled is false (see bug 1889569).

Comment 1

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello, thank you for the bug report!
Managed to reproduce this issue on:

• Firefox Nightly 145.0a1;
• Firefox 144.0b3;

Tested on:

• Windows 10;
• Ubuntu 22;
• macOS 15;

Comment 2

[Mike Kaply [:mkaply]]

This seems like an overall bug in the hidden feature in Quickactions?

Comment 3

[Henry Wilkes (they/them) [:henry-x]]

I came across this for the "translate" action being listed in the full actions list, despite it being disabled.

This seems like an overall bug in the hidden feature in Quickactions?

Yes, this is a general problem for all actions that are meant to be hidden. Only ProviderQuickActions.queryActions will filter with isVisible. But UrlbarProviderActionsSearchMode calls ActionsProviderQuickActions.getActions directly, which doesn't filter them out.

Comment 4

[Dale Harvey (:daleharvey)]

This is partly by design, the quickactions are not filtered in actions search mode because the search mode is specifically a way to list available actions for users to discover what is available even if they are not currently applicable. However there is a bug that actions that are not usable should be shown as disabled, currently they are marked as disabled but styled the same as the rest of the buttons

Comment 5

[Mike Kaply [:mkaply]]

But actions that are explicitly not available (for instance via enterprise policy), shouldn't show at all.

Comment 6

[Dale Harvey (:daleharvey)]

Yeh seems reasonable if a feature can never be enabled then it shouldnt show. Instead of fiddling with filtering available actions, I dont think actions like these should be loaded at all (they are loaded @ https://searchfox.org/firefox-main/source/browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs)

Comment 7

[Mike Kaply [:mkaply]]

Attachment: Bug 1989252 - Don't show unavailable quickactions in action mode. r?daleharvey

Comment 8

[Mike Kaply [:mkaply]]

Yeh seems reasonable if a feature can never be enabled then it shouldnt show. Instead of fiddling with filtering available actions, I dont think actions like these should be loaded at all (they are loaded @ https://searchfox.org/firefox-main/source/browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs)

Does that loader get invoked everytime or just at runtime? Because the policy can be dynamic.

There was already a capability in Quickactions for isActive versus isVisible, it just wasn't being used.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dd6f2fcf8197
https://hg.mozilla.org/integration/autoland/rev/05ac32723be1
Don't show unavailable quickactions in action mode. r=daleharvey,urlbar-reviewers,mak

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0372164bf317
https://hg.mozilla.org/integration/autoland/rev/9619a95c6d24
Revert "Bug 1989252 - Don't show unavailable quickactions in action mode. r=daleharvey,urlbar-reviewers,mak" for causing xpc failures @test_quickaction_telemetry.js.

Comment 11

[agoloman]

Backed out for causing xpc failures @test_quickaction_telemetry.js.

• Backout link
• Push with failures
• Failure Log

Comment 12

[Mike Kaply [:mkaply]]

Missed because it's a debug only assert. Added workaround.

Ran try build to verify fix.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/22e2727ab23d
https://hg.mozilla.org/integration/autoland/rev/e4bc554fdd09
Don't show unavailable quickactions in action mode. r=daleharvey,urlbar-reviewers,mak

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e4bc554fdd09

Comment 15

[Cristian Baica [:cbaica], Release Desktop QA]

Managed to reproduce the issue using Fx 154.0RC.
The issue is verified fixed using Fx 155.0b1 and Fx 156.0a1 on Windows 11, macOS and Ubuntu 24. Print pdf is no longer available in quick actions if print is disabled in about:config.