1889828 - Intermittent tools/profiler/tests/xpcshell/test_feature_posix_signals.js | single tracking bug

Status: NEW

(Core :: Gecko Profiler, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=453571385&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Jw3pkC6LT2GfmJQi_AkLIw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2024-04-05T00:32:51.671Z] 00:32:51     INFO -  TEST-PASS | xpcshell.toml:browser/components/extensions/test/xpcshell/test_ext_browsingData_settings.js | took 3164ms
[task 2024-04-05T00:32:51.676Z] 00:32:51     INFO -  TEST-START | tools/profiler/tests/xpcshell/test_feature_posix_signals.js
[task 2024-04-05T00:32:51.965Z] 00:32:51  WARNING -  TEST-UNEXPECTED-FAIL | tools/profiler/tests/xpcshell/test_feature_posix_signals.js | xpcshell return code: 0
[task 2024-04-05T00:32:51.965Z] 00:32:51     INFO -  TEST-INFO took 266ms
[task 2024-04-05T00:32:51.965Z] 00:32:51     INFO -  >>>>>>>
[task 2024-04-05T00:32:51.965Z] 00:32:51     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-04-05T00:32:51.965Z] 00:32:51     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  running event loop
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  tools/profiler/tests/xpcshell/test_feature_posix_signals.js | Starting
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  (xpcshell/head.js) | test pending (2)
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  "Test that stopping the profiler with a posix signal works."
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should not begin the test active. - true == true
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-04-05T00:32:51.966Z] 00:32:51     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/brand.properties"
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should now be active. - true == true
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - Raising a SIGUSR2 signal should succeed. - {"ok":true} == true
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  (xpcshell/head.js) | test finished (1)
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  exiting test
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (1)
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  (xpcshell/head.js) | test finished (1)
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  exiting test
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  tools/profiler/tests/xpcshell/test_feature_posix_signals.js | Starting
[task 2024-04-05T00:32:51.967Z] 00:32:51     INFO -  (xpcshell/head.js) | test pending (1)
[task 2024-04-05T00:32:51.968Z] 00:32:51     INFO -  "Test that stopping the profiler with a posix signal writes a profile file to the system download directory."
[task 2024-04-05T00:32:51.968Z] 00:32:51     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should not begin the test active. - true == true
[task 2024-04-05T00:32:51.968Z] 00:32:51     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (1)
[task 2024-04-05T00:32:51.968Z] 00:32:51     INFO -  exiting test
[task 2024-04-05T00:32:51.968Z] 00:32:51  WARNING -  TEST-UNEXPECTED-FAIL | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should now be active. - false == true
[task 2024-04-05T00:32:51.968Z] 00:32:51     INFO -  /opt/worker/tasks/task_171227572750761/build/tests/xpcshell/tests/tools/profiler/tests/xpcshell/test_feature_posix_signals.js:null:175
[task 2024-04-05T00:32:51.968Z] 00:32:51     INFO -  /opt/worker/tasks/task_171227572750761/build/tests/xpcshell/head.js:_execute_test:672
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  -e:null:1
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  exiting test
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  _abort_failed_test@/opt/worker/tasks/task_171227572750761/build/tests/xpcshell/head.js:869:20
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  do_report_result@/opt/worker/tasks/task_171227572750761/build/tests/xpcshell/head.js:981:5
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  Assert<@/opt/worker/tasks/task_171227572750761/build/tests/xpcshell/head.js:70:21
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  Assert.prototype.report@resource://testing-common/Assert.sys.mjs:251:10
[task 2024-04-05T00:32:51.969Z] 00:32:51     INFO -  Assert.prototype.ok@resource://testing-common/Assert.sys.mjs:277:10
[task 2024-04-05T00:32:51.970Z] 00:32:51     INFO -  @/opt/worker/tasks/task_171227572750761/build/tests/xpcshell/tests/tools/profiler/tests/xpcshell/test_feature_posix_signals.js:175:10
[task 2024-04-05T00:32:51.970Z] 00:32:51     INFO -  _execute_test@/opt/worker/tasks/task_171227572750761/build/tests/xpcshell/head.js:672:16
[task 2024-04-05T00:32:51.970Z] 00:32:51     INFO -  @-e:1:1
[task 2024-04-05T00:32:51.970Z] 00:32:51     INFO -  exiting test
[task 2024-04-05T00:32:51.970Z] 00:32:51     INFO -  <<<<<<<
[task 2024-04-05T00:32:51.970Z] 00:32:51     INFO -  TEST-START | dom/base/test/unit/test_error_codes.js

Comment 1

[Intermittent Failures Robot]

18 failures in 3805 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 13
• mozilla-central: 5

Platform and build breakdown:

• macosx1015-64-shippable-qr: 11
  • opt: 11
• macosx1015-64-qr: 7
  • debug: 2
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1889828&startday=2024-04-01&endday=2024-04-07&tree=all

Comment 2

[Natalia Csoregi [:nataliaCs]]

Update

There have been 47 total failures within the last 7 days:

• 21 failures on OS X 10.15 WebRender opt/ debug
• 26 failures on OS X 10.15 WebRender Shippable opt

Recent log: https://treeherder.mozilla.org/logviewer?job_id=454426464&repo=mozilla-central&lineNumber=6862

Adam, any chance your changes in Bug 1865930 might have triggered this?
Thank you.

Comment 3

[Florian Quèze [:florian]]

The test seems to mix two different ways of making an async xpcshell tests.

From the documentation, you can either use add_task with an async function (https://firefox-source-docs.mozilla.org/testing/xpcshell/index.html#task-based-asynchronous-tests) or call do_test_finished() as many times as you called do_test_pending() (https://firefox-source-docs.mozilla.org/testing/xpcshell/index.html#other-tests).

I see do_test_finished calls in the test but no do_test_pending(), and the test log for failures shows:

  (xpcshell/head.js) | test finished (1)
  exiting test

twice between the 2 subtests.

Comment 4

[Intermittent Failures Robot]

45 failures in 3235 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #9 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 35
• mozilla-central: 10

Platform and build breakdown:

• macosx1015-64-qr: 21
  • opt: 16
  • debug: 5
• macosx1015-64-shippable-qr: 24
  • opt: 24

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1889828&startday=2024-04-08&endday=2024-04-14&tree=all

Comment 5

[Adam Brouwers-Harries [:aabh] [he/him] ⌚GMT]

The test seems to mix two different ways of making an async xpcshell tests.

Ah, good point. I wasn't very familiar with how we write xpcshell tests before this bug, so I'll revisit them and make sure they're correctly written.

Comment 6

[Intermittent Failures Robot]

35 failures in 4252 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #49 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 33
• mozilla-central: 2

Platform and build breakdown:

• macosx1015-64-qr: 19
  • opt: 17
  • debug: 2
• macosx1015-64-shippable-qr: 16
  • opt: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1889828&startday=2024-04-15&endday=2024-04-21&tree=all