Closed Bug 1891751 Opened 2 months ago Closed 2 months ago

Correct usages of async xpcshell test API for posix signal feature tests

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: aabh, Assigned: aabh)

References

Details

Attachments

(1 file)

Bug 1891751 - Remove extraneous xpcshell testing api calls. r=#profiler-reviewers,florian
48 bytes, text/x-phabricator-request
Details | Review

See comment 3 on the blocked bug.

Pushed by abrouwersharries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63fbb3b2873c
Remove extraneous xpcshell testing api calls. r=florian,profiler-reviewers

Backed out for causing xpcshell failures on test_feature_posix_signals.js.

task 2024-04-18T00:52:55.562Z] 00:52:55     INFO -  TEST-START | tools/profiler/tests/xpcshell/test_feature_posix_signals.js
[task 2024-04-18T00:52:55.602Z] 00:52:55     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DEVELOPER_OBJ_DIR=/builds/worker/workspace/obj-build --es env6 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env7 MOZ_FETCHES_DIR=/builds/worker/fetches --es env8 MOZ_DISABLE_SOCKET_PROCESS=1 --es env9 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env10 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env11 GRE_HOME=/data/local/tmp/test_root/xpcb --es env12 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/2cdd00b2-280a-479c-bf62-507ce4ba785d --es env13 HOME=/data/local/tmp/test_root/xpc/p --es env14 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/bf527846-74f4-47ef-921a-1dd259479d13 --es env15 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env16 MOZ_IN_AUTOMATION=1 --es env17 MOZ_ANDROID_CPU_ABI=x86_64 --es env18 MOZHTTP2_PORT=39830 --es env19 MOZNODE_EXEC_PORT=37255 --es env20 MOZHTTP3_ECH= --es env21 TMPDIR=/data/local/tmp/test_root/xpc/p/2cdd00b2-280a-479c-bf62-507ce4ba785d --es env22 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/2cdd00b2-280a-479c-bf62-507ce4ba785d --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-test_runner.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/2cdd00b2-280a-479c-bf62-507ce4ba785d/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = ["/data/local/tmp/test_root/xpc/tools/profiler/tests/xpcshell/head.js"];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/tools/profiler/tests/xpcshell";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_feature_posix_signals.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "tools/profiler/tests/xpcshell/test_feature_posix_signals.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --ez use_multiprocess True --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-62aacf65-9580-4f12-ad7b-ccdc8952a927.log
[task 2024-04-18T00:52:55.811Z] 00:52:55     INFO -  remotexpcshelltests.py | tools/profiler/tests/xpcshell/test_feature_posix_signals.js | 9003 | Launched Test App
[task 2024-04-18T00:53:07.467Z] 00:53:07     INFO -  remotexpcshelltests.py | tools/profiler/tests/xpcshell/test_feature_posix_signals.js | 9003 | Application ran for: 0:00:11.904652
[task 2024-04-18T00:53:07.522Z] 00:53:07  WARNING -  TEST-UNEXPECTED-FAIL | tools/profiler/tests/xpcshell/test_feature_posix_signals.js | xpcshell return code: 0
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  TEST-INFO took 11959ms
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  >>>>>>>
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  running event loop
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  tools/profiler/tests/xpcshell/test_feature_posix_signals.js | Starting
[task 2024-04-18T00:53:07.522Z] 00:53:07     INFO -  (xpcshell/head.js) | test pending (2)
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  "Test that stopping the profiler with a posix signal works."
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should not begin the test active. - true == true
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should now be active. - true == true
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - Raising a SIGUSR2 signal should succeed. - {"ok":true} == true
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should now be inactive. - true == true
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  (xpcshell/head.js) | test finished (2)
[task 2024-04-18T00:53:07.523Z] 00:53:07     INFO -  tools/profiler/tests/xpcshell/test_feature_posix_signals.js | Starting
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  (xpcshell/head.js) | test pending (2)
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  "Test that stopping the profiler with a posix signal writes a profile file to the system download directory."
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should not begin the test active. - true == true
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - The profiler should now be active. - true == true
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  TEST-PASS | tools/profiler/tests/xpcshell/test_feature_posix_signals.js |  - Raising a SIGUSR2 signal should succeed. - {"ok":true} == true
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  Unexpected exception Waiting for a profile file to be written to disk. - timed out after 50 tries.
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  undefined
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  exiting test
[task 2024-04-18T00:53:07.524Z] 00:53:07     INFO -  <<<<<<<
[task 2024-04-18T00:53:07.587Z] 00:53:07     INFO -  Cleaning up profile for /builds/worker/workspace/build/tests/xpcshell/tests/tools/profiler/tests/xpcshell/test_feature_posix_signals.js folder: /data/local/tmp/test_root/xpc/p/2cdd00b2-280a-479c-bf62-507ce4ba785d
[task 2024-04-18T00:53:07.756Z] 00:53:07     INFO -  INFO | Result summary:
[task 2024-04-18T00:53:07.756Z] 00:53:07     INFO -  INFO | Passed: 17
[task 2024-04-18T00:53:07.756Z] 00:53:07  WARNING -  INFO | Failed: 1
[task 2024-04-18T00:53:07.756Z] 00:53:07  WARNING -  One or more unittests failed.
[task 2024-04-18T00:53:07.756Z] 00:53:07     INFO -  INFO | Todo: 0
[task 2024-04-18T00:53:07.756Z] 00:53:07     INFO -  INFO | Retried: 1
[task 2024-04-18T00:53:07.756Z] 00:53:07     INFO -  SUITE-END | took 32s
[task 2024-04-18T00:53:07.756Z] 00:53:07     INFO -  Node moz-http2 server shutting down ...
[task 2024-04-18T00:53:07.777Z] 00:53:07     INFO - Return code: 1
Flags: needinfo?(abrouwersharries)
Pushed by abrouwersharries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b196ac64ccb
Remove extraneous xpcshell testing api calls. r=florian,profiler-reviewers
Flags: needinfo?(abrouwersharries)

https://hg.mozilla.org/mozilla-central/rev/4b196ac64ccb

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: