1890129 - Beta: Wordmark in about dialog is always black

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Also with dark theme is the wordmark in about dialog always black .

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1890129 - Don't hard code wordmark color. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/32654db35022
Don't hard code wordmark color. r=aleca

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9395394 [details]
Bug 1890129 - Don't hard code wordmark color. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
User impact if declined: Thunderbird wordmark not white with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Is this a regression in version 115?

Comment 5

[Richard Marti (:Paenglab)]

No, this affects beta only.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9395394 [details]
Bug 1890129 - Don't hard code wordmark color. r=#thunderbird-front-end-reviewers

[Triage Comment]
Skipping uplift, because it's not destined for 115.

Comment 7

[Richard Marti (:Paenglab)]

approval-comm-beta is for 125 (beta, which is affected) and not ESR, or not?

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Richard Marti (:Paenglab) from comment #7)

approval-comm-beta is for 125 (beta, which is affected) and not ESR, or not?

correct, but beta 126 is only a week away.