Handle Same Language Selected in Select Translations Panel
Categories
(Firefox :: Translations, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: nordzilla, Assigned: nordzilla)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
Description
This bug tracks the progress of handling selecting the same from-language as the to-language in the Select Translations Panel.
The current implementation disallows this by ensuring that this state cannot occur.
However, the desired UX behavior is to simply pass through the source text as though it was translated.
Steps to implement
- Remove the logic that prevents this state from occurring.
- Pass through the source text as though it was translated from one language to the same language.
Tests to implement
- Remove the tests that ensure this state cannot occur.
- Add tests that check for the source text being passed through.
|
Assignee | |
Comment 1•2 months ago
|
||
Adds the ability for the Translator abstraction to be
a PassthroughTranslator in the case where the source
language and the target language are the same and the
consumer wants the behavior of passing the source text
directly through as a same-language translation.
|
|
Assignee | |
Comment 2•2 months ago
|
||
Refactors some of the SelectTranslationsPanel test
assertions to explicitly wait for the panel to fire
an event upon changing state.
|
|
Assignee | |
Comment 3•2 months ago
|
||
Allows the SelectTranslationsPanel to have the same
from-language and to-language selected, in which case
the source text will be passed through unaltered as
the same-language translation.
|
||
Updated•2 months ago
|
|
|
||
Updated•2 months ago
|
|
|
||
Updated•2 months ago
|
Pushed by enordin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d9b70a5b2c7 Add PassthroughTranslator Implementation r=translations-reviewers,gregtatum https://hg.mozilla.org/integration/autoland/rev/6ed14cad5fb0 Refactor Translations Test Assertions r=translations-reviewers,gregtatum https://hg.mozilla.org/integration/autoland/rev/aad7caf1a025 Allow SelectTranslationsPanel Same Language r=translations-reviewers,gregtatum
|
||
Comment 5•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8d9b70a5b2c7
https://hg.mozilla.org/mozilla-central/rev/6ed14cad5fb0
https://hg.mozilla.org/mozilla-central/rev/aad7caf1a025
Description
•