1890494 - The translation button no longer works in the previous window after a new window is opened

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: translations.gif

Found in

• 125.0

Affected versions

• 126.0a1 (2024-04-08)
• 125.0
• 124.0.2

Tested platforms

• Affected platforms: macOS 14, Windows 10x64, Ubuntu 23
• Unaffected platforms: none

Steps to reproduce

1. Open https://es.wikipedia.org/wiki/Wikipedia:Portada in one window.
2. Open a new window.
3. Click on the Translation button in the initially opened window.

Expected result

• The translation panel is opened.

Actual result

• Nothing happens.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fb12eabe9c08f7665f775dcdc4edb9095d1f2acf&tochange=478632b0cc4982639276a4a817165ac49ca8fb6e
  Possible regressor: bug 1846828

Additional notes

• Attached a screen recording.
• S3 because it is an old issue.
• This happens with multiple normal and private windows.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:gregtatum, since you are the author of the regressor, bug 1846828, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1846828

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1890494 - Add capabilities to provide a ChromeWindow to some of the translations test utils; r?#translations-reviewers!

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1890494 - Fix the translations icon when there are multiple windows; r?#translations-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56743e41f604
Add capabilities to provide a ChromeWindow to some of the translations test utils; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/cb2ed7f65c97
Fix the translations icon when there are multiple windows; r=translations-reviewers,nordzilla

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/56743e41f604
https://hg.mozilla.org/mozilla-central/rev/cb2ed7f65c97

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gregtatum, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Greg Tatum [:gregtatum]]

Comment on attachment 9396954 [details]
Bug 1890494 - Fix the translations icon when there are multiple windows; r?#translations-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: The translations button will sometimes not work when switching between multiple windows until a user navigates the page.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR is in the initial bug description.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code changed is part of the core way we offer translations to users, and if that breaks it could be annoying to users if it pops up unexpectedly. While this change could be a medium risk, I think if we uplift it early enough in the cycle it shouldn't be a big issue, as it will have plenty of time to be vetted before going to release.
• String changes made/needed:
• Is Android affected?: Unknown

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 127.0a1 (2024-04-17) on Windows 10x64, macOS 14, and Ubuntu 23.10. The translation button is working after following the steps from comment 0.

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9396954 [details]
Bug 1890494 - Fix the translations icon when there are multiple windows; r?#translations-reviewers!

Approved for 126.0b3

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca7aea884fde
https://hg.mozilla.org/releases/mozilla-beta/rev/b8e1b6e28162

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 126.0b3 on Windows 10x64, macOS 14, and Ubuntu 23.10. The translation button is working after following the steps from comment 0.