1890523 - Remove extra space above/below stretchy operators

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang (:fredw)]

We have https://searchfox.org/mozilla-central/rev/c09764753ea40725eb50decad2c51edecbd33308/layout/mathml/nsMathMLmoFrame.cpp#594 but it's not part of MathML Core and is causing several WPT failures.

I'm not clear whether this is an important typographic rule that should be in the spec or just some tweaks that were done in the early days of MathML to work around broken fonts...

I'm proposing to tentatively unship this.

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Bug 1890523 - Remove extra space above/below stretchy operators. r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a7c866d716d
Remove extra space above/below stretchy operators. r=emilio

Comment 3

[tszentpeteri]

Backed out for causing wpt failures in stretchy-largeop-with-default-font-2.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /mathml/presentation-markup/operators/stretchy-largeop-with-default-font-2.html | Test that non-stretchy largeops are bigger in display mode. - assert_greater_than: size of largeop '⨃' expected a number greater than 19 but got 19

Comment 4

[Frédéric Wang (:fredw)]

Android does not have proper math fonts installed, so it's very likely that some of these tests fail. I believe the issue was hidden before the patch because we were adding extra space.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3531a1b13af3
Remove extra space above/below stretchy operators. r=emilio

Comment 6

[pstanciu]

Backed out for causing wpt failures in table-width-1.xhtml and in stretchy-largeop-with-default-font-2.html

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | /mathml/relations/css-styling/table-width-1.xhtml | Testing http://web-platform.test:8000/mathml/relations/css-styling/table-width-1.xhtml == http://web-platform.test:8000/mathml/relations/css-styling/table-width-1-ref.xhtml

• Failure Log
• Failure Line:

TEST-UNEXPECTED-FAIL | /mathml/presentation-markup/operators/stretchy-largeop-with-default-font-2.html | Test that non-stretchy largeops are bigger in display mode. - assert_greater_than: size of largeop '⨀' expected a number greater than 25 but got 25

Comment 7

[Frédéric Wang (:fredw)]

OK, I sent another try with WPT tests on all the platforms: https://treeherder.mozilla.org/jobs?repo=try&revision=ccf67d80f4e5acbbe15fbb39b7272085562fc7c2&selectedTaskRun=OYF9ovFZTimDpUm2K1e8FA.0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff639c7b8eb2
Remove extra space above/below stretchy operators. r=emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45687 for changes under testing/web-platform/tests

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ff639c7b8eb2

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot