Closed Bug 1890749 Opened 7 months ago Closed 5 months ago

Don't need to pass onFormSubmit callback to FormStateManager

Categories

(Toolkit :: Form Autofill, task)

Product:
Toolkit
Component:
Form Autofill
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1898745

People

(Reporter: dimi, Assigned: dimi)

References

Details

(Whiteboard: [fxcm-iframe])

Attachments

(1 obsolete file)

No description provided.

After fixing Bug 1883090 (move logic from FormAutofillContent to FormAutofillChild).
We don't need to pass onFormSubmit to FormStateManager because
form submission call is always triggered from FormAutofillChild.

Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e5127ed93b0d Don't need to pass onFormSubmit callback to FormStateManager r=credential-management-reviewers,sgalich

Backed out for causing mochitest failures on browser_address_capture_page_navigation.js.

[task 2024-04-23T08:10:51.888Z] 08:10:51     INFO - TEST-START | browser/extensions/formautofill/test/browser/address/browser_address_capture_page_navigation.js
[task 2024-04-23T08:10:51.933Z] 08:10:51     INFO - GECKO(1063) | [Child 1374: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f592847b800 == 1 [pid = 1374] [id = 0]
[task 2024-04-23T08:10:51.935Z] 08:10:51     INFO - GECKO(1063) | [Child 1374: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (7f5927b27020) [pid = 1374] [serial = 1] [outer = 0]
[task 2024-04-23T08:10:51.936Z] 08:10:51     INFO - GECKO(1063) | [Child 1374: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7f592847e800) [pid = 1374] [serial = 2] [outer = 7f5927b27020]
[task 2024-04-23T08:10:52.137Z] 08:10:52     INFO - GECKO(1063) | [Child 1374: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f5928481400) [pid = 1374] [serial = 3] [outer = 7f5927b27020]
[task 2024-04-23T08:10:52.430Z] 08:10:52     INFO - GECKO(1063) | [Child 1374, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0xC1F30001 (NS_ERROR_NOT_INITIALIZED): file /builds/worker/checkouts/gecko/layout/forms/nsTextControlFrame.cpp:307
[task 2024-04-23T08:10:52.432Z] 08:10:52     INFO - GECKO(1063) | [Child 1374, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0xC1F30001 (NS_ERROR_NOT_INITIALIZED): file /builds/worker/checkouts/gecko/layout/forms/nsTextControlFrame.cpp:307
[task 2024-04-23T08:10:52.433Z] 08:10:52     INFO - GECKO(1063) | [Child 1374, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0xC1F30001 (NS_ERROR_NOT_INITIALIZED): file /builds/worker/checkouts/gecko/layout/forms/nsTextControlFrame.cpp:307
[task 2024-04-23T08:10:52.434Z] 08:10:52     INFO - GECKO(1063) | [Child 1374, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0xC1F30001 (NS_ERROR_NOT_INITIALIZED): file /builds/worker/checkouts/gecko/layout/forms/nsTextControlFrame.cpp:307
[task 2024-04-23T08:10:52.477Z] 08:10:52     INFO - GECKO(1063) | [Child 1374, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/checkouts/gecko/layout/generic/nsFrameSelection.cpp:1626
[task 2024-04-23T08:10:52.959Z] 08:10:52     INFO - GECKO(1063) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmppei3l6en.mozrunner/runtests_leaks_tab_pid1460.log
[task 2024-04-23T08:10:52.979Z] 08:10:52     INFO - GECKO(1063) | [Child 1460, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:720
[task 2024-04-23T08:10:54.931Z] 08:10:54     INFO - GECKO(1063) | [Parent 1063: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (7f0c2d81cc00) [pid = 1063] [serial = 4] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:54.933Z] 08:10:54     INFO - GECKO(1063) | [Parent 1063: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (7f0c28faf000) [pid = 1063] [serial = 9] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.622Z] 08:10:55     INFO - GECKO(1063) | [Child 1208: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7f9dfea7bc00) [pid = 1208] [serial = 4] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.622Z] 08:10:55     INFO - GECKO(1063) | [Child 1208: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7f9dfea76800) [pid = 1208] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.623Z] 08:10:55     INFO - GECKO(1063) | [Child 1208: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7f9dfea78000) [pid = 1208] [serial = 3] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.636Z] 08:10:55     INFO - GECKO(1063) | [Child 1208: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f9dfea7d800 == 0 [pid = 1208] [id = 1] [url = about:blank]
[task 2024-04-23T08:10:55.754Z] 08:10:55     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 17 (7fd663182c00) [pid = 1160] [serial = 8] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.757Z] 08:10:55     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 16 (7fd663183c00) [pid = 1160] [serial = 10] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.758Z] 08:10:55     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 15 (7fd663180400) [pid = 1160] [serial = 4] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.758Z] 08:10:55     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 14 (7fd663181800) [pid = 1160] [serial = 6] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.758Z] 08:10:55     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 13 (7fd661ea6800) [pid = 1160] [serial = 17] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:55.758Z] 08:10:55     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (7fd66317e800) [pid = 1160] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:57.164Z] 08:10:57     INFO - GECKO(1063) | [Child 1264: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fef6d27d400 == 1 [pid = 1264] [id = 0] [url = about:blank]
[task 2024-04-23T08:10:57.174Z] 08:10:57     INFO - GECKO(1063) | [Child 1264: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (7fef6c980020) [pid = 1264] [serial = 1] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:58.424Z] 08:10:58     INFO - GECKO(1063) | [Child 1311: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fc13f586800) [pid = 1311] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-04-23T08:10:59.710Z] 08:10:59     INFO - GECKO(1063) | [Child 1208: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7f9dfe1243e0) [pid = 1208] [serial = 5] [outer = 0] [url = about:blank]
[task 2024-04-23T08:11:01.669Z] 08:11:01     INFO - GECKO(1063) | [Child 1264: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fef6d280400) [pid = 1264] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-04-23T08:11:03.882Z] 08:11:03     INFO - GECKO(1063) | [Child 1208: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7f9dfea7dc00) [pid = 1208] [serial = 6] [outer = 0] [url = about:blank]
[task 2024-04-23T08:11:04.321Z] 08:11:04     INFO - GECKO(1063) | [Child 1374: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7f592847e800) [pid = 1374] [serial = 2] [outer = 0] [url = about:blank]
[task 2024-04-23T08:11:14.320Z] 08:11:14     INFO - GECKO(1063) | [Child 1160, Main Thread] WARNING: JSWindowActorChild::SendRawMessage (Conduits, ConduitClosed) not sent: !CanSend() || !mManager || !mManager->CanSend(): file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:61
[task 2024-04-23T08:11:22.412Z] 08:11:22     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fd663182800 == 5 [pid = 1160] [id = 3] [url = moz-extension://bc9d8ae9-aacd-4ad4-bd5a-4f24a9f311e6/_generated_background_page.html]
[task 2024-04-23T08:11:26.918Z] 08:11:26     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (7fd66367eb60) [pid = 1160] [serial = 7] [outer = 0] [url = moz-extension://bc9d8ae9-aacd-4ad4-bd5a-4f24a9f311e6/_generated_background_page.html]
[task 2024-04-23T08:11:31.094Z] 08:11:31     INFO - GECKO(1063) | [Child 1160: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (7fd661e9e400) [pid = 1160] [serial = 14] [outer = 0] [url = moz-extension://bc9d8ae9-aacd-4ad4-bd5a-4f24a9f311e6/_generated_background_page.html]
[task 2024-04-23T08:12:21.893Z] 08:12:21     INFO - TEST-INFO | started process screentopng
[task 2024-04-23T08:12:22.185Z] 08:12:22     INFO - TEST-INFO | screentopng: exit 0
[task 2024-04-23T08:12:22.185Z] 08:12:22     INFO - Buffered messages logged at 08:10:51
[task 2024-04-23T08:12:22.186Z] 08:12:22     INFO - Entering setup bound 
[task 2024-04-23T08:12:22.187Z] 08:12:22     INFO - Leaving setup bound 
[task 2024-04-23T08:12:22.187Z] 08:12:22     INFO - Entering setup bound 
[task 2024-04-23T08:12:22.188Z] 08:12:22     INFO - Leaving setup bound 
[task 2024-04-23T08:12:22.188Z] 08:12:22     INFO - Entering test bound test_address_captured_after_changing_request_state
[task 2024-04-23T08:12:22.189Z] 08:12:22     INFO - Buffered messages logged at 08:10:52
[task 2024-04-23T08:12:22.189Z] 08:12:22     INFO - Update identified address fields
[task 2024-04-23T08:12:22.190Z] 08:12:22     INFO - focus on element (id=given-name)
[task 2024-04-23T08:12:22.190Z] 08:12:22     INFO - Change request state
[task 2024-04-23T08:12:22.191Z] 08:12:22     INFO - Wait for address doorhanger
[task 2024-04-23T08:12:22.191Z] 08:12:22     INFO - Buffered messages finished
[task 2024-04-23T08:12:22.192Z] 08:12:22     INFO - TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/address/browser_address_capture_page_navigation.js | Test timed out - 
[task 2024-04-23T08:12:22.193Z] 08:12:22     INFO - GECKO(1063) | Completed ShutdownLeaks collections in process 1063
[task 2024-04-23T08:12:22.193Z] 08:12:22     INFO - TEST-START | Shutdown
Flags: needinfo?(dlee)
Flags: needinfo?(dlee)
Whiteboard: [fxcm-iframe]

Hello, head's up that prior to back-out this also broke all autofill/credit-card related Fenix (Android) instrumented UI tests with primarily select_credit_card_header and select_credit_card_header not in view when expected after adding an address, and attempting autofill on forms.

From the video, the select prompt is never displayed on field select

Firebase Test Lab Matrix: (link)[https://console.firebase.google.com/u/0/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/8088100405523136904/executions/bs.fa4a46a40c2d37fb/testcases/2/video] (ping me over Slack for access)

This broke the following (ui-test-arm) https://treeherder.mozilla.org/jobs?repo=autoland&revision=e5127ed93b0d4f14ad15c8092d18e8a97da28325&selectedTaskRun=AABiqrRtTGC3op5W0mhkCg.0

  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.AddressAutofillTest#verifyAddressAutofillToggleTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.AddressAutofillTest#verifyFormFieldCanBeFilledManuallyTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyEditedCardIsSavedTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.AddressAutofillTest#verifyAddressAutofillTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyConfirmCreditCardUpdatePromptTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyManageCreditCardsPromptOptionTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyDoNotSaveCreditCardFromPromptTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.AddressAutofillTest#verifyManageAddressesPromptOptionTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyCancelCreditCardUpdatePromptTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyMultipleCreditCardsCanBeAddedTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifySaveCreditCardFromPromptTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyCreditCardsAutofillToggleTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.CreditCardAutofillTest#verifyCreditCardAutofillTest
  • Pixel2.arm-30-en_US-portrait org.mozilla.fenix.ui.AddressAutofillTest#verifyMultipleAddressesSelectionTest

Source: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/AddressAutofillTest.kt

Source: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/CreditCardAutofillTest.kt

Currently fixed with back-out, but

I'll defer working on this patch until Bug 1884632 is landed.

Attachment #9395984 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 5 months ago
Duplicate of bug: 1898745
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: