1890802 - Cancel button is not visible in HCM

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Simona Badau, Desktop QA, PTO 13-25aug]

Attachment: Screenshot with the issue

Found in

• Nightly 126.0a1

Affected versions

• Nightly 126.0a1

Tested platforms

• Affected platforms: macOS 13, Ubuntu 22.04.
• Unaffected platforms: Windows 10 x64

Preconditions

• Enable High Contrast Mode.

Steps to reproduce

1. Enable Screenshots by pressing the Cmd+Shift+S keys.
2. Observe the Cancel button and mouse hover over it.

Expected result

• The Cancel button should be visible, and the mouse hover effect should be noticeable.

Actual result

• The Cancel button and the mouse hover effect are barely visible. Please see the screenshot attached.

Regression range

• Yes, this is not reproducible on Firefox 125.0b5 or earlier versions when Screenshots component is enabled (screenshots.browser.component.enabled is set to true).

• Found commit message:
  Bug 1881405: Use the forced-colors media query instead of prefers-contrast when styles depend on system colors in privacy.css r=ayeddi,settings-reviewers,desktop-theme-reviewers,emilio

• Pushlog:
  https://hg.mozilla.org/integration/autoland/json-pushes?changeset=033b661b349ec9f221fe7453bef9e57d74fcade2&full=1

Additional notes

• This issue is not reproducible on Windows 10.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:morgan, since you are the author of the regressor, bug 1881405, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Anna Yeddi [:ayeddi]]

Marking it as access-s3 because while the button is not visible on HCM, there are on-screen instructions for the alternative way to dismiss the screenshot mode (by pressing Esc key), thus the flow is not blocked

Comment 3

[Anna Yeddi [:ayeddi]]

The change above is happened because we are moving from using prefers-contrast query for high contrast mode (HCM) to forced-colors which affects only Windows OS when contrast theme is active or when certain settings is activated in the Firefox Settings > General > Colors dialog on other OSes. More about the audit and more about semantic use of these queries can be found in meta bug 1877780.

Comment 4

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1890802 - Update overlay.css in Screenshots to use forced-colors instead of prefers-contrast where appropriate. r?sfoster,niklas,morgan

As part of the HCM and Increased Contrast Support in FX project, the Accessibility team is auditing existing prefers-contrast media query blocks in mozilla-central. For each block with prefers-contrast media we want to convert it to forced-colors where appropriate.

Refer to the bug 1877780 #c0 for more information about the project.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1881405

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/291d187ba249
Update overlay.css in Screenshots to use forced-colors instead of prefers-contrast where appropriate. r=niklas,morgan,desktop-theme-reviewers,dao

Comment 7

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/291d187ba249

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox126 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Anna Yeddi [:ayeddi]]

AFAIK, the new implementation is to be shipped in Firefox 127 where the fix is riding the train, so we could avoid the Beta uplift since it's not enabled by default in there.

Comment 10

[Simona Badau, Desktop QA, PTO 13-25aug]

Verified as fixed using the latest Nightly 127.0a1 (Build ID: 20240425212929) on macOS 13 and Windows 10 x64.