Fix "Choose a language" regression in FullPageTranslationsPanel
Categories
(Firefox :: Translations, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox124 | --- | unaffected |
| firefox125 | --- | unaffected |
| firefox126 | --- | verified |
People
(Reporter: nordzilla, Assigned: nordzilla)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Description
In Bug 1870316 (revision D204975) I introduced behavior that removes items from the translations panel menu lists by default when they are initialized. This way tests can clear and reset all of the initialized values between tests.
This works well for the Select Translations Panel, which is designed to localize the menu list labels with "Choose a language" if no value is selected.
However, for the Full Page Translations Panel, the "Choose a language" value is actually a selectable menu item in the menu-list dropdown, and this code is causing that item to be removed from the lists.
This will need to be fixed in a way that works for both panel implementations.
Steps to Reproduce Issue #1
- Open a fresh browser window.
- Go to the website https://gl.wikipedia.org (a language that we do not support for translation at the time of writing).
- Click the Application Menu (hamburger icon at the top corner of the browser UI).
- Navigate to the "Translate this page..." menu item and click it.
- When prompted that this language is not supported, click the "Choose another source language" button.
Expected Behavior
The "Translate From" menu list value should be set to "Choose a language"
Actual Behavior
The "Translate From" menu list value is set to Bulgarian (the first language in the list at the time of writing).
Steps to Reproduce Issue #2
- Open a fresh browser window.
- Go to the website https://es.wikipedia.org (a language that we do support for translation at the time of writing).
- Wait for the FullPageTranslationsPanel to open. It should open automatically.
- Go to the website https://gl.wikipedia.org (a language that we do not support for translation at the time of writing).
- Click the Application Menu (hamburger icon at the top corner of the browser UI).
- Navigate to the "Translate this page..." menu item and click it.
- When prompted that this language is not supported, click the "Choose another source language" button.
Expected Behavior
The "Translate From" menu list value should be set to "Choose a language"
Actual Behavior
The "Translate From" menu list value blank, when it should have a value.
|
Assignee | |
Comment 1•2 months ago
|
||
Renames this test because it had the word "engine" in the file name,
but this test does not test the translations engine.
|
|
Assignee | |
Comment 2•2 months ago
|
||
Fixes an issue where the default "Choose a language"
menu item was accidentally being removed from the
FullPageTranslationsPanel menu lists.
Depends on D207217
|
||
Updated•2 months ago
|
|
|
||
Updated•2 months ago
|
|
||
Comment 3•2 months ago
|
||
Set release status flags based on info from the regressing bug 1870316
Pushed by enordin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1faf0d06b366 Rename FullPageTranslationsPanel unsupported-lang test r=translations-reviewers,gregtatum https://hg.mozilla.org/integration/autoland/rev/22504850ba40 Fix FullPagePanel lang-list initialization r=translations-reviewers,gregtatum
|
||
Comment 5•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1faf0d06b366
https://hg.mozilla.org/mozilla-central/rev/22504850ba40
I was able to replicate this issue on an affected Firefox Nightly build from 126.0a1 (2024-04-10), under Windows 11, while following the steps described in Comment 0.
Verified as fixed on Firefox RC 126.0-build2, using macOS 12.6.6, Windows 11 and Ubuntu 22.04.
For both Issue 1 and Issue 2, the "Translate From" menu list value is set to "Choose a language"
Description
•