Closed Bug 1870316 Opened 5 months ago Closed 2 months ago

Automatically translate selection when Select Translations Panel opens

Categories

(Firefox :: Translations, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: nordzilla, Assigned: nordzilla)

References

(Blocks 2 open bugs)

Details

Attachments

(13 files, 1 obsolete file)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Description

This bug tracks the progress of having the Select Translations Panel auto-translate and populate the translated text when the panel is opened.

This will involve creating new actors to utilize the Single Process Translations Engine.


Steps to implement

  • Add new actors for Select Translations to utilize the Single Process Translations Engine
  • Invoke Translations upon panel open
  • Switch to the Problem Translating View UI on error
  • Invoke Translations upon from-language switch
  • Invoke Translations upon to-language switch

Tests to implement

  • Test that translation occurs automatically on panel open.
  • Test that the translation is correct.
  • Test that the "Problem Translating" view is displayed on error.
  • Test success and error cases when switching from-language
  • Test success and error cases when switching to-language
Blocks: 1870320
Depends on: 1870327
Blocks: 1870332
Blocks: 1870334
Depends on: 1878721
No longer depends on: 1878721
Depends on: 1880357
Assignee: nobody → enordin
Attachment #9387946 - Attachment description: WIP: Bug 1870316 - WIP → WIP: Bug 1870316 - Misc. Translations test fixes

Depends on D204975

Comment on attachment 9391850 [details]
WIP: Bug 1870316 - Move Translator class to Translator.sys.mjs

Revision D204976 was moved to bug 1884901. Setting attachment 9391850 [details] to obsolete.

Attachment #9391850 - Attachment is obsolete: true
Attachment #9387946 - Attachment description: WIP: Bug 1870316 - Misc. Translations test fixes → Bug 1870316 - Misc. Translations test fixes r=#translations-reviewers!
Attachment #9391845 - Attachment description: WIP: Bug 1870316 - Rename switchSelectedLanguage to changeSelectedLanguage → Bug 1870316 - Rename switchSelectedLanguage to changeSelectedLanguage r=#translations-reviewers!
Attachment #9391846 - Attachment description: WIP: Bug 1870316 - Create custom test page for Select Translations → Bug 1870316 - Create custom test page for Select Translations r=#translations-reviewers!
Attachment #9391847 - Attachment description: WIP: Bug 1870316 - Refactor getTranslationsActor → Bug 1870316 - Refactor getTranslationsActor r=#translations-reviewers!
Attachment #9391848 - Attachment description: WIP: Bug 1870316 - Refactor Translations assertSelectedLanguage → Bug 1870316 - Refactor Translations assertSelectedLanguage r=#translations-reviewers!
Attachment #9391849 - Attachment description: WIP: Bug 1870316 - Add clearCache to TranslationsPanelShared → Bug 1870316 - Add clearCache to TranslationsPanelShared r=#translations-reviewers!
Attachment #9391851 - Attachment description: WIP: Bug 1870316 - SelectTranslationsPanel Misc. Renames/Refactors → Bug 1870316 - SelectTranslationsPanel Misc. Renames/Refactors r=#translations-reviewers!
Attachment #9391852 - Attachment description: WIP: Bug 1870316 - SelectTranslationsPanel Translate on open → Bug 1870316 - SelectTranslationsPanel Translate on open r=#translations-reviewers!
Attachment #9391854 - Attachment description: WIP: Bug 1870316 - SelectTranslationsPanel Default Focus → Bug 1870316 - SelectTranslationsPanel Default Focus r=#translations-reviewers!
Attachment #9391855 - Attachment description: WIP: Bug 1870316 - SelectTranslationsPanel Translate on Change Language → Bug 1870316 - SelectTranslationsPanel Translate on Change Language r=#translations-reviewers!
Attachment #9391856 - Attachment description: WIP: Bug 1870316 - SelectTranslationsPanel Enable/Disable Buttons → Bug 1870316 - SelectTranslationsPanel Enable/Disable Buttons r=#translations-reviewers!
Attachment #9391857 - Attachment description: WIP: Bug 1870316 - SelectTranslationsPanel Dynamic Height → Bug 1870316 - SelectTranslationsPanel Dynamic Height r=#translations-reviewers!
Attachment #9391858 - Attachment description: WIP: Bug 1870316 - SelectTranslationsPanel Text Direction → Bug 1870316 - SelectTranslationsPanel Text Direction r=#translations-reviewers!
Attachment #9391856 - Attachment description: Bug 1870316 - SelectTranslationsPanel Enable/Disable Buttons r=#translations-reviewers! → Bug 1870316 - SelectTranslationsPanel Enabled State r=#translations-reviewers!
Blocks: 1887953
Pushed by enordin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2acc1e4037bf
Misc. Translations test fixes r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/23d4207989d0
Rename switchSelectedLanguage to changeSelectedLanguage r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/afa6abfbfe3d
Create custom test page for Select Translations r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/75ca737184aa
Refactor getTranslationsActor r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/abf2a358f448
Refactor Translations assertSelectedLanguage r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/5fe9d2cd653a
Add clearCache to TranslationsPanelShared r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/0cd68b79ecf6
SelectTranslationsPanel Misc. Renames/Refactors r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/8dd2a8b4e1c8
SelectTranslationsPanel Translate on open r=translations-reviewers,fluent-reviewers,bolsson,gregtatum
https://hg.mozilla.org/integration/autoland/rev/4bd00aa51474
SelectTranslationsPanel Default Focus r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/78d4068c892e
SelectTranslationsPanel Translate on Change Language r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/8595d2916949
SelectTranslationsPanel Enabled State r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/90dfb94db5ae
SelectTranslationsPanel Dynamic Height r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/079e08696da5
SelectTranslationsPanel Text Direction r=translations-reviewers,gregtatum
Regressions: 1890089
Regressions: 1890897
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: