1891053 - [Menu Redesign] Use preview parameters for all of the state permutations in MozillaAccountMenuItem

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

From https://phabricator.services.mozilla.com/D207053#7112025, we want apply preview parameters for all of the state permutations inside of MozillaAccountMenuButton.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Also see https://phabricator.services.mozilla.com/D207054#7112051 about applying this in MenuDialog

Comment 2

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Marking as WONTFIX. Current preview in https://searchfox.org/firefox-main/rev/542208dcdb891e1efa70d9411d612c0ee0726dd8/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/header/MozillaAccountMenuItem.kt#208 already appears to fulfill what we wanted to accomplish in this bug.

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Reopening since we could use preview parameters to simply this.

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1891053 - [Menu Redesign] Use preview parameters for all of the state permutations in MozillaAccountMenuItem

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b84a0d1b0163
https://hg.mozilla.org/integration/autoland/rev/5bfb16297a03
[Menu Redesign] Use preview parameters for all of the state permutations in MozillaAccountMenuItem r=android-reviewers,adhingra

Comment 7

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/5bfb16297a03