1885602 - [Menu Redesign] Implement header

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task)

Description

[Roger Yang [:royang]]

Implement header (Sign in, info icon and settings button)

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9751-50236&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885602 - Part 1: Add strings for the sign in header in the menu redesign

Source: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9751-50236&mode=dev

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49b15fea2cfb
Part 1: Add strings for the sign in header in the menu redesign r=android-reviewers,Roger

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing fenix lint failure

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b417e1de56b6
Part 1: Add strings for the sign in header in the menu redesign r=android-reviewers,Roger

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b417e1de56b6

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign

Source:
https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9751-50040&mode=dev
https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9940-23719&mode=dev

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885602 - Part 3: Add MenuHeader for the menu redesign

Source: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9940-23719&mode=dev

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign

• Introduces a MenuStore with a isBookmarked placeholder state.
• Introduces a MenuNavigationMiddleware to handle menu navigation actions.
• Implements navigating to the settings from the settings button in the menu header.

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53e4ae5b1993
Part 2: Add a MozillaAccountMenuButton composable for the menu redesign r=007,android-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/124f8c8ad1da
Part 3: Add MenuHeader for the menu redesign r=android-reviewers,007
https://hg.mozilla.org/integration/autoland/rev/505f15e016b9
Part 4: Implement navigating to the settings from the menu header for the menu redesign r=android-reviewers,007,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/038d0fb7ecd8
Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign r=android-reviewers,matt-tighe,007

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/53e4ae5b1993

Comment 13

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/124f8c8ad1da
https://hg.mozilla.org/mozilla-central/rev/505f15e016b9
https://hg.mozilla.org/mozilla-central/rev/038d0fb7ecd8