Closed Bug 1885602 Opened 1 year ago Closed 11 months ago

[Menu Redesign] Implement header

Categories

(Fenix :: Toolbar, task)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

(firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: royang, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid])

Attachments

(5 files)

Bug 1885602 - Part 1: Add strings for the sign in header in the menu redesign
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885602 - Part 3: Add MenuHeader for the menu redesign
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign
48 bytes, text/x-phabricator-request
Details | Review
Summary: Implement header → [Menu Redesign] Implement header
Blocks: menu-redesign
Whiteboard: [fxdroid]
Severity: -- → S2
Severity: S2 → S3
Severity: S3 → N/A
Assignee: nobody → gl
Status: NEW → ASSIGNED
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49b15fea2cfb Part 1: Add strings for the sign in header in the menu redesign r=android-reviewers,Roger

Backed out for causing fenix lint failure

Backout link

Push with failures

Failure log

Flags: needinfo?(gl)
Flags: needinfo?(gl)
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b417e1de56b6 Part 1: Add strings for the sign in header in the menu redesign r=android-reviewers,Roger
Keywords: leave-open
  • Introduces a MenuStore with a isBookmarked placeholder state.
  • Introduces a MenuNavigationMiddleware to handle menu navigation actions.
  • Implements navigating to the settings from the settings button in the menu header.
Attachment #9395829 - Attachment description: WIP: Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign → Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign
Attachment #9395830 - Attachment description: WIP: Bug 1885602 - Part 3: Add MenuHeader for the menu redesign → Bug 1885602 - Part 3: Add MenuHeader for the menu redesign
Attachment #9395831 - Attachment description: WIP: Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign → Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign
Attachment #9395832 - Attachment description: WIP: Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign → Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign
Attachment #9395829 - Attachment description: Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign → WIP: Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign
Attachment #9395830 - Attachment description: Bug 1885602 - Part 3: Add MenuHeader for the menu redesign → WIP: Bug 1885602 - Part 3: Add MenuHeader for the menu redesign
Attachment #9395831 - Attachment description: Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign → WIP: Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign
Attachment #9395832 - Attachment description: Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign → WIP: Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign
Attachment #9395829 - Attachment description: WIP: Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign → Bug 1885602 - Part 2: Add a MozillaAccountMenuButton composable for the menu redesign
Attachment #9395830 - Attachment description: WIP: Bug 1885602 - Part 3: Add MenuHeader for the menu redesign → Bug 1885602 - Part 3: Add MenuHeader for the menu redesign
Attachment #9395831 - Attachment description: WIP: Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign → Bug 1885602 - Part 4: Implement navigating to the settings from the menu header for the menu redesign
Attachment #9395832 - Attachment description: WIP: Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign → Bug 1885602 - Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign
Blocks: 1891053
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53e4ae5b1993 Part 2: Add a MozillaAccountMenuButton composable for the menu redesign r=007,android-reviewers
Keywords: leave-open
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/124f8c8ad1da Part 3: Add MenuHeader for the menu redesign r=android-reviewers,007 https://hg.mozilla.org/integration/autoland/rev/505f15e016b9 Part 4: Implement navigating to the settings from the menu header for the menu redesign r=android-reviewers,007,matt-tighe https://hg.mozilla.org/integration/autoland/rev/038d0fb7ecd8 Part 5: Implement navigating to the SUMO help topic from the menu header in the menu redesign r=android-reviewers,matt-tighe,007
Flags: qe-verify-

https://hg.mozilla.org/mozilla-central/rev/53e4ae5b1993

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Blocks: 1891253
No longer blocks: menu-redesign
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: