Closed Bug 1891209 Opened 8 months ago Closed 8 months ago

Perma Linux 18.04 x64 opt node typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:361: error TS2300: Duplicate identifier 'ChromeUtils'.

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect

Tracking

(firefox-esr115 unaffected, firefox125 unaffected, firefox126 fixed, firefox127 fixed)

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox125 --- unaffected
firefox126 --- fixed
firefox127 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: julienw)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1891209 - Add a "typeRoots" entry to tsconfig.json so that TypeScript doesn't use global types r=nchevobbe
48 bytes, text/x-phabricator-request
dmeehan
: approval-mozilla-beta+
Details | Review

Filed by: tszentpeteri [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=454377178&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eK3lY1Y7Tc2dy3VHxA_5FQ/runs/0/artifacts/public/logs/live_backing.log

[task 2024-04-12T09:47:26.287Z] TEST START | typescript | performance
[task 2024-04-12T09:47:26.287Z] [devtools-node-test-runner] Run `yarn test` in test folder
[task 2024-04-12T09:47:26.287Z] [devtools-node-test-runner] Error log
[task 2024-04-12T09:47:26.287Z] error Command failed with exit code 2.
[task 2024-04-12T09:47:26.287Z] 
[task 2024-04-12T09:47:26.287Z] [devtools-node-test-runner] Parse errors from the test logs
[task 2024-04-12T09:47:26.287Z] yarn run v1.22.18
[task 2024-04-12T09:47:26.287Z] $ tsc
[task 2024-04-12T09:47:26.287Z] @types/gecko.d.ts(361,13): error TS2300: Duplicate identifier 'ChromeUtils'.
[task 2024-04-12T09:47:26.287Z] @types/gecko.d.ts(363,13): error TS2300: Duplicate identifier 'PathUtils'.
[task 2024-04-12T09:47:26.287Z] @types/gecko.d.ts(374,19): error TS2430: Interface 'ChromeDocument' incorrectly extends interface 'Document'.
[task 2024-04-12T09:47:26.287Z] @types/gecko.d.ts(391,19): error TS2430: Interface 'ChromeHTMLElement' incorrectly extends interface 'HTMLElement'.
[task 2024-04-12T09:47:26.287Z]   Types of property 'ownerDocument' are incompatible.
[task 2024-04-12T09:47:26.287Z]     Type 'ChromeDocument' is not assignable to type 'Document'.
[task 2024-04-12T09:47:26.287Z] @types/gecko.d.ts(395,19): error TS2430: Interface 'XULElement' incorrectly extends interface 'Element'.
[task 2024-04-12T09:47:26.287Z] @types/gecko.d.ts(395,19): error TS2430: Interface 'XULElement' incorrectly extends interface 'HTMLElement'.
[task 2024-04-12T09:47:26.287Z]   Types of property 'ownerDocument' are incompatible.
[task 2024-04-12T09:47:26.287Z]     Type 'ChromeDocument' is not assignable to type 'Document'.
[task 2024-04-12T09:47:26.287Z] @types/gecko.d.ts(416,3): error TS2687: All declarations of 'browsingContext' must have identical modifiers.
[task 2024-04-12T09:47:26.288Z] @types/gecko.d.ts(445,15): error TS2300: Duplicate identifier 'ChromeWorker'.
[task 2024-04-12T09:47:26.288Z] @types/gecko.d.ts(469,14): error TS2300: Duplicate identifier 'nsIPrefBranch'.
[task 2024-04-12T09:47:26.288Z] @types/perf.d.ts(651,11): error TS2503: Cannot find namespace 'WebAssembly'.
[task 2024-04-12T09:47:26.288Z] aboutprofiling/initializer.js(27,5): error TS18004: No value exists in scope for the shorthand property 'window'. Either declare one or provide an initializer.
[task 2024-04-12T09:47:26.288Z] aboutprofiling/initializer.js(127,5): error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.288Z] aboutprofiling/initializer.js(130,3): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] aboutprofiling/initializer.js(135,35): error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.288Z] aboutprofiling/initializer.js(140,5): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] aboutprofiling/initializer.js(141,3): error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.288Z] components/aboutprofiling/Settings.js(274,29): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] components/panel/DevToolsPanel.js(60,39): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] components/panel/OnboardingMessage.js(95,23): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] panel/initializer.js(31,5): error TS18004: No value exists in scope for the shorthand property 'window'. Either declare one or provide an initializer.
[task 2024-04-12T09:47:26.288Z] panel/initializer.js(106,43): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] panel/initializer.js(181,5): error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.288Z] panel/initializer.js(184,3): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] panel/initializer.js(188,35): error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.288Z] popup/logic.sys.mjs(74,33): error TS2352: Conversion of type 'HTMLElement' to type 'MenuListElement' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
[task 2024-04-12T09:47:26.288Z]   Type 'HTMLElement' is missing the following properties from type 'MenuListElement': value, disabled, collapsed, contextMenu, and 9 more.
[task 2024-04-12T09:47:26.288Z] popup/logic.sys.mjs(169,37): error TS2345: Argument of type 'XULElement' is not assignable to parameter of type 'Element'.
[task 2024-04-12T09:47:26.288Z]   Types of property 'ownerDocument' are incompatible.
[task 2024-04-12T09:47:26.288Z]     Type 'ChromeDocument' is not assignable to type 'Document'.
[task 2024-04-12T09:47:26.288Z] popup/logic.sys.mjs(177,34): error TS2345: Argument of type 'XULElement' is not assignable to parameter of type 'string | Node'.
[task 2024-04-12T09:47:26.288Z]   Type 'XULElement' is not assignable to type 'Node'.
[task 2024-04-12T09:47:26.288Z]     Types of property 'ownerDocument' are incompatible.
[task 2024-04-12T09:47:26.288Z]       Type 'ChromeDocument' is not assignable to type 'Document'.
[task 2024-04-12T09:47:26.288Z] popup/logic.sys.mjs(280,14): error TS2345: Argument of type 'MenuListElement' is not assignable to parameter of type 'HTMLElement'.
[task 2024-04-12T09:47:26.288Z]   Types of property 'ownerDocument' are incompatible.
[task 2024-04-12T09:47:26.288Z]     Type 'ChromeDocument' is not assignable to type 'Document'.
[task 2024-04-12T09:47:26.288Z] popup/menu-button.sys.mjs(72,27): error TS2339: Property 'querySelector' does not exist on type 'Document'.
[task 2024-04-12T09:47:26.288Z] popup/menu-button.sys.mjs(165,39): error TS2345: Argument of type 'XULElement | ChromeHTMLElement' is not assignable to parameter of type 'XULElement'.
[task 2024-04-12T09:47:26.288Z]   Type 'ChromeHTMLElement' is missing the following properties from type 'XULElement': collapsed, contextMenu, controllers, menu, and 7 more.
[task 2024-04-12T09:47:26.288Z] shared/background.sys.mjs(772,36): error TS2345: Argument of type 'ChromeDocument' is not assignable to parameter of type 'Document'.
[task 2024-04-12T09:47:26.288Z]   Types of property 'l10n' are incompatible.
[task 2024-04-12T09:47:26.288Z]     Type 'FluentLocalization' is missing the following properties from type 'DocumentL10n': ready, connectRoot, disconnectRoot, getAttributes, and 15 more.
[task 2024-04-12T09:47:26.288Z] shared/background.sys.mjs(816,9): error TS2322: Type 'JSON' is not assignable to type 'ResponseToFrontend'.
[task 2024-04-12T09:47:26.288Z]   Type 'JSON' is missing the following properties from type 'ArrayBuffer': byteLength, slice
[task 2024-04-12T09:47:26.288Z] shared/background.sys.mjs(830,9): error TS2322: Type 'JSON' is not assignable to type 'ResponseToFrontend'.
[task 2024-04-12T09:47:26.288Z] shared/symbolication.sys.mjs(56,20): error TS2503: Cannot find namespace 'WebAssembly'.
[task 2024-04-12T09:47:26.288Z] shared/symbolication.sys.mjs(75,14): error TS2304: Cannot find name 'WebAssembly'.
[task 2024-04-12T09:47:26.288Z] shared/symbolication.sys.mjs(107,17): error TS2315: Type 'MessageEvent' is not generic.
[task 2024-04-12T09:47:26.288Z] store/actions.js(205,25): error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(3947,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(3981,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4001,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4076,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4095,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4105,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4120,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4133,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4165,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.288Z] ../../../tools/@types/lib.gecko.dom.d.ts(4237,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
<...>
[task 2024-04-12T09:47:26.303Z] ../../../tools/@types/lib.gecko.dom.d.ts(35340,16): error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.303Z] ../../../tools/@types/lib.gecko.xpcom.d.ts(9657,11): error TS2300: Duplicate identifier 'nsIPrefBranch'.
[task 2024-04-12T09:47:26.303Z] ../../../tools/@types/lib.gecko.xpcom.d.ts(12181,23): error TS2304: Cannot find name 'nativeWindow'.
[task 2024-04-12T09:47:26.303Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2024-04-12T09:47:26.303Z] 
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:361: error TS2300: Duplicate identifier 'ChromeUtils'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:363: error TS2300: Duplicate identifier 'PathUtils'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:374: error TS2430: Interface 'ChromeDocument' incorrectly extends interface 'Document'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:391: error TS2430: Interface 'ChromeHTMLElement' incorrectly extends interface 'HTMLElement'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:395: error TS2430: Interface 'XULElement' incorrectly extends interface 'Element'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:395: error TS2430: Interface 'XULElement' incorrectly extends interface 'HTMLElement'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:416: error TS2687: All declarations of 'browsingContext' must have identical modifiers.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:445: error TS2300: Duplicate identifier 'ChromeWorker'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:469: error TS2300: Duplicate identifier 'nsIPrefBranch'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/perf.d.ts:651: error TS2503: Cannot find namespace 'WebAssembly'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newaboutprofiling/initializer.js:27: error TS18004: No value exists in scope for the shorthand property 'window'. Either declare one or provide an initializer.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newaboutprofiling/initializer.js:127: error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newaboutprofiling/initializer.js:130: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newaboutprofiling/initializer.js:135: error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newaboutprofiling/initializer.js:140: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newaboutprofiling/initializer.js:141: error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newcomponents/aboutprofiling/Settings.js:274: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newcomponents/panel/DevToolsPanel.js:60: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newcomponents/panel/OnboardingMessage.js:95: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpanel/initializer.js:31: error TS18004: No value exists in scope for the shorthand property 'window'. Either declare one or provide an initializer.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpanel/initializer.js:106: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpanel/initializer.js:181: error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpanel/initializer.js:184: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpanel/initializer.js:188: error TS2584: Cannot find name 'document'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpopup/logic.sys.mjs:74: error TS2352: Conversion of type 'HTMLElement' to type 'MenuListElement' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpopup/logic.sys.mjs:169: error TS2345: Argument of type 'XULElement' is not assignable to parameter of type 'Element'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpopup/logic.sys.mjs:177: error TS2345: Argument of type 'XULElement' is not assignable to parameter of type 'string | Node'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newpopup/logic.sys.mjs:280: error TS2345: Argument of type 'MenuListElement' is not assignable to parameter of type 'HTMLElement'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newbutton.sys.mjs:72: error TS2339: Property 'querySelector' does not exist on type 'Document'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newbutton.sys.mjs:165: error TS2345: Argument of type 'XULElement | ChromeHTMLElement' is not assignable to parameter of type 'XULElement'.
[task 2024-04-12T09:47:26.303Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newshared/background.sys.mjs:772: error TS2345: Argument of type 'ChromeDocument' is not assignable to parameter of type 'Document'.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newshared/background.sys.mjs:816: error TS2322: Type 'JSON' is not assignable to type 'ResponseToFrontend'.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newshared/background.sys.mjs:830: error TS2322: Type 'JSON' is not assignable to type 'ResponseToFrontend'.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newshared/symbolication.sys.mjs:56: error TS2503: Cannot find namespace 'WebAssembly'.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newshared/symbolication.sys.mjs:75: error TS2304: Cannot find name 'WebAssembly'.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newshared/symbolication.sys.mjs:107: error TS2315: Type 'MessageEvent' is not generic.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newstore/actions.js:205: error TS2304: Cannot find name 'window'.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:3947: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:3981: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4001: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4076: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4095: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4105: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4120: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4133: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4165: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4237: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4253: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4273: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4294: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.304Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:4306: error TS7006: Parameter 'obj' implicitly has an 'any' type.
<...>
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35268: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35277: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35286: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35295: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35304: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35313: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35322: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35331: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.dom.d.ts:35340: error TS7006: Parameter 'obj' implicitly has an 'any' type.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.xpcom.d.ts:9657: error TS2300: Duplicate identifier 'nsIPrefBranch'.
[task 2024-04-12T09:47:26.320Z] TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/lib.gecko.xpcom.d.ts:12181: error TS2304: Cannot find name 'nativeWindow'.
[task 2024-04-12T09:47:26.320Z] [devtools-node-test-runner] Running suite: shared_components
[task 2024-04-12T09:47:26.320Z] [devtools-node-test-runner] Run `yarn` in test folder
[task 2024-04-12T09:47:26.320Z] TEST START | jest | shared_components

This popped up after today's merge (autoland -> central), as you can see here. There are multiple typescript | performance related failures on this path, please refer to the log for more information.

Severity: S4 → --
Priority: P5 → --
Summary: Perma node typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:361: error TS2300: Duplicate identifier 'ChromeUtils'. → Perma Linux 18.04 x64 opt node typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:361: error TS2300: Duplicate identifier 'ChromeUtils'.

Do we know what patch could have caused this?

Flags: needinfo?(tszentpeteri)

I don't reproduce on central nor autoland. Can you please give me some instructions to reproduce the environment where this happens?

I think this is because of bug 1890144.
But I don't know why this happens in CI but not locally.

Keywords: regression
Regressed by: 1890144

We could add something such as

"typeRoots": ["."]

to our tsconfig.json, to avoid this.
(see https://www.typescriptlang.org/tsconfig/#typeRoots)

But without reproducing locally I can't be sure...

Managed to reproduce: when calling ./mach eslint in the root, a bunch of things are installed in the root node_modules, and they're being picked up by TS.

I believe something similar happens in CI when this is run before running the tests:

cp -r /build/node_modules_eslint node_modules && cp -r /build/node_modules_eslint-plugin-mozilla/ tools/lint/eslint/eslint-plugin-mozilla/node_modules && ln -s ../tools/lint/eslint/eslint-plugin-mozilla node_modules && ln -s ../tools/lint/eslint/eslint-plugin-spidermonkey-js node_modules

Now I'm gonna try my fix...

The global types are not ready for this and conflict with our usage.
In the future we'll want to merge them though.

Assignee: nobody → felash
Status: NEW → ASSIGNED

Comment on attachment 9396620 [details]
Bug 1891209 - Add a "typeRoots" entry to tsconfig.json so that TypeScript doesn't use global types r=nchevobbe

Beta/Release Uplift Approval Request

  • User impact if declined: none
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a test-only change, there's no app code involved.

I'll be away later today and fairly busy this week, so I anticipate this uplift because I see that the regressing bug is in beta too.

Here is the try for this change on nightly => https://treeherder.mozilla.org/jobs?repo=try&revision=f55f3493c2a8449e33aef8528ede7f516cd6616a

  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9396620 - Flags: approval-mozilla-beta?
Flags: needinfo?(tszentpeteri)
Pushed by jwajsberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ffa9bf5e7d0d Add a "typeRoots" entry to tsconfig.json so that TypeScript doesn't use global types r=nchevobbe,devtools-reviewers

https://hg.mozilla.org/mozilla-central/rev/ffa9bf5e7d0d

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch

Comment on attachment 9396620 [details]
Bug 1891209 - Add a "typeRoots" entry to tsconfig.json so that TypeScript doesn't use global types r=nchevobbe

Approved for 126.0b2

Attachment #9396620 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Set release status flags based on info from the regressing bug 1890144

status-firefox125: --- → unaffected
status-firefox-esr115: --- → unaffected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: