1891372 - message list context menues show useless spacing for every menu item

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

Since bug 1875802 there is a large gap on the left side for every menu item which looks odd. Please see the attached screenshot. Submenus are affected as well.

Tested on Thunderbird Daily 126.0a1 (2024-04-09) on macOS 14.4.1.

Comment 1

[Richard Marti (:Paenglab)]

Alex, what do you think?
This is simply doable but then possible Add-on menuitems would loose their icons (are there a lot of extensions using this?).
When I'm on it I could do the same on some sub menus without checkmarks/icons in this context menu.

Comment 2

[Sören Hentzschel]

but then possible Add-on menuitems would loose their icons

Is it possible to detect if any of the menu items on this menu level has an icon, and only remove the gap if there are no icons?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1891372 - Remove the empty space in front of the message context menu. r=#thunderbird-front-end-reviewers

Comment 4

[Alessandro Castellani [:aleca]]

John, could you check this patch and see how that context menu behaves with an add-on adding a menuitem with an icon?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: Comparison.png

Comparison of the menu with an Add-on menuitem.

Comment 6

[John Bieling (:TbSync)]

Attachment: windows.png

This is how the change looks to me on Windows.

Comment 7

[John Bieling (:TbSync)]

Attachment: image.png

If the add-on does not have an icon, the space is still preserved.

Note: Add-on icons should not be removed from the menu, as they are an indicator to the user, which entry is from an add-on, and from which add-on. Add-on developers cannot freely change that icon, it is always the default add-on icon defined in the manifest and used everywhere for that purpose.

I guess that almost all add-ons using the menus API have a default icon defined. I would even argue, that we should not "fix" the observed extra space for add-ons, as add-on developers will probably resort to using an icon if they see this. This will then be more in line with what we actually want: Clear identification of menu entries generated by add-ons.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ba70c39931ec
Remove the empty space in front of the message context menu. r=freaktechnik,john.bieling