Closed Bug 1891568 Opened 2 years ago Closed 2 years ago

Add unit tests for functionality of text and layout controls

Categories

(Toolkit :: Reader Mode, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: ini, Assigned: ini)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

blocker level bug for rolling out new theme and layout menus.

At the moment, we only have unit test coverage for opening/closing the menu dropdown, but not the actual functionality of the controls. We want to add a set of unit tests that make sure that setting the text and layout properties result in the correct styling changes. The approach can be similar to the tests for setting color themes, where we set the pref to a certain value, load up a mock article in Reader View, and use getComputedStyle() to check if the custom css variable has the correct value.

Assignee: nobody → ini
Pushed by ini@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/647350331989 Add unit tests for functionality of text and layout controls. r=reader-mode-reviewers,desktop-theme-reviewers,frontend-codestyle-reviewers,Itiel,Standard8,cmkm
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: