1891599 - Create PiP JWPlayer Wrapper

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Joseph Webster]

Attachment: AOL PiP - JWPlayer.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36

Steps to reproduce:

I can reproduce this bug by following the steps below:

1. Navigate to https://www.aol.com/o-j-simpson-former-nfl-145545988.html
2. Play the video
3. Click Picture-In-Picture toggle
4. Click Closed Captioning logo and enable English subtitles

Actual results:

PiP "subtitles" icon remains disabled and PiP subtitles do not appear.

Expected results:

PiP "subtitles" icon should be clickable and PiP subtitles should be visible

Comment 1

[Joseph Webster]

Note: This bug assumes that Bug 1825105 (https://bugzilla.mozilla.org/show_bug.cgi?id=1825105#c8) is already merged with Firefox Nightly (this patch was landed earlier today 4/15/24).

Comment 2

[kpatenio]

Thanks for filing this bug! Feel free to assign yourself on Bugzilla and submit a patch tagging #pip-reviewers once it's ready for review.

Changing ticket type to "defect" since, technically speaking, there's unexpected results tied to this behaviour.

Comment 3

[Joseph Webster]

Attachment: Bug 1891599 - Create PiP JWPlayer Wrapper r=kpatenio

Comment 4

[Joseph Webster]

Attachment: Bug 1891599 - Create PiP JWPlayer Wrapper r=kpatenio

Comment 5

[Joseph Webster]

Attachment: Bug 1891599 - Create PiP JWPlayer Wrapper r=kpatenio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc6fe766b0cb
Create PiP JWPlayer Wrapper r=niklas

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/cc6fe766b0cb

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-04-15 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 128.0a1 and Firefox 127.0b2 on Windows 10, macOS 12, Ubuntu 22.