1891729 - The main menu is incorrectly displayed when the keyboard is dismissed

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P1)

Description

[Vasilica Tamas QA [:vtamas]]

Attachment: mainmenu.mp4

Steps to reproduce

1. Launch Fenix and navigate to any site that with a text box (ie wikipedia.org)
2. Tap on the search field.
3. Tap on 3 dots menu.

Expected behavior

The main menu is displayed from the bottom of the screen.

Actual behavior

The keyboard is hiding and the menu remains displayed in the middle of the screen.

Device information

• Firefox version: Firefox Nightly 127 (2024-04-16), Firefox 126 Beta 1
• Android device model: OnePLus 6T (Android 11), Xiaomi 12T (Android 12)

Any additional information?

• This issue is a regression: Last Good build (2024-03-18) - First Bad build (2024-03-20) - there is no Nightly build from 2024-03-19

Comment 1

[Donal Meehan [:dmeehan]]

:bclark could this be triaged for investigation?
The regression window in comment 0 is large since it includes the firefox-android merge to mozilla-central

Comment 2

[Roger Yang [:royang]]

This looks like a regression from toolbar redesign feature. We're are currently undergoing to a large refactor so we can restore behaviour cleanly when toolbar redesign feature is not on. I'll move this into the toolbar redesign work. Thanks

Comment 3

[Roger Yang [:royang]]

I can reproduce this in Nighty and in Beta with toolbar redesign feature NOT turned on. I do not know which change caused the regression but this week I will be working on reverting all toolbar redesign implementation and refactor them into the toolbar2 component. We will then uplift this to Beta.

Comment 4

[Roger Yang [:royang]]

Did a search and found out that this is not toolbar redesign related. This issue was caused by Bug1854131. I'll mark it as the cause of the regression.

Comment 5

[Roger Yang [:royang]]

Hi :mcarare, can you please take a look? I did the search and confirm that this was caused by Bug 1854131

Comment 6

[Mihai Adrian Carare [:mcarare]]

I will look into it, thanks for pinging me.

I can confirm that the change in 1854131 caused the regression, but I think the problem lies in the way we display the PopupWindow, the calculation is correct.

Comment 7

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1891729 - Refactor logic for menu positioning.

Comment 8

[Donal Meehan [:dmeehan]]

:mcarare we have one week left in Beta for Fx126.
It seems the patch for this is complex to take in an uplift.

What do you think about us reverting the regressor from Beta? Though Bug 1854131 is an S2, it's not a recent bug.

Comment 9

[Mihai Adrian Carare [:mcarare]]

Yes, I think this patch is too complex for a Beta uplift.

And I don't think we should uplift a revert either because the fixed issue was more severe than the one caused by the fix.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b00a65bc2a6
Refactor logic for menu positioning. r=android-reviewers,twhite

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1854131

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1b00a65bc2a6

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mcarare, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Mihai Adrian Carare [:mcarare]]

The patch is too complex to warrant an uplift.

Comment 15

[Delia Pop (Android QA)]

Attachment: ImportedPhoto_1715785956075.jpg

Verified as fixed on the latest Nightly 128.0a1 from 05/15 with Samsung Galaxy S22 Ultra (Android 14). The main menu is now displayed from the bottom of the screen after the keyboard is dismissed.