Closed
Bug 1891782
Opened 6 months ago
Closed 6 months ago
Eliminate Inline Event Handlers From SelectTranslationsPanel
Categories
(Firefox :: Translations, task, P3)
Firefox
Translations
Tracking
()
RESOLVED
FIXED
127 Branch
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: nordzilla, Assigned: nordzilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Description
See Bug 1890547 for more context.
This bug tracks the progress of removing all inline event handlers from the SelectTranslationsPanel markup.
As part of the greater effort to remove inline event handlers from the browser window, we should ensure that SelectTranslationsPanel does not have any upon release.
Steps to implement
- Remove all
oncommand,onpopupshown,onpopuphiddeninline event handlers from selectTranslationsPanel.inc.xhtml - Lazily initialize all relevant event listeners in selectTranslationsPanel.js
Tests to implement
- The changes should preserve the exact same behavior as before. Preexisting test coverage is sufficient.
|
Assignee | |
Comment 1•6 months ago
|
||
Removes inline event handlers from the markup for the
SelectTranslationsPanel, instead initializing them lazily
from the JavaScript directly.
|
||
Updated•6 months ago
|
Attachment #9396943 -
Attachment description: WIP: Bug 1891782 - Eliminate inline event handlers from SelectTranslationsPanel → Bug 1891782 - Eliminate inline event handlers from SelectTranslationsPanel r=#translations-reviewers!
Pushed by enordin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbe98fdbc350
Eliminate inline event handlers from SelectTranslationsPanel r=translations-reviewers,gregtatum
|
||
Comment 3•6 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox127:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•