Closed
Bug 1891982
Opened 1 year ago
Closed 1 year ago
Duplicate TopSitesFeed and relevant tests into a separate component
Categories
(Firefox :: Top Sites, task, P2)
Firefox
Top Sites
Tracking
()
RESOLVED
FIXED
127 Branch
Tracking | Status | |
---|---|---|
firefox127 | --- | fixed |
People
(Reporter: jteow, Assigned: jteow)
References
(Blocks 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(2 files)
TopSitesFeed.sys.mjs will be duplicated into browser/components/topsites/TopSites.sys.mjs
.
Likewise browser/components/newtab/test/xpcshell/test_TopSitesFeed.js
.
The component should be called TopSites to avoid confusion with TopSitesFeed.
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Assignee | ||
Comment 2•1 year ago
|
||
Avoiding renaming all references to TopSitesFeed (especially in tests) until
after I remove extraneous code and refactor in stages the component code.
Depends on D207827
Pushed by jteow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46b9f1bb340b
Part 1: Copy Top Sites Feed into the Top Sites component - r=dao,frontend-codestyle-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/21035f8f528d
Part 2: Do minimal renaming of TopSitesFeed to TopSites - r=dao
https://hg.mozilla.org/mozilla-central/rev/46b9f1bb340b
https://hg.mozilla.org/mozilla-central/rev/21035f8f528d
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox127:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•