189205 - Implement early shutdown of NSS resources

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kai Engert [:KaiE:]]

For background discussion, see also comments in bug 177260.

We would like to land the portions that were initially posted in that other bug,
and that allow an early shutdown of NSS resources, even if some XPCom objects
are still referenced by the world outside of PSM.

However, we still require a certain level of good behaviour from the outside
world. We require that all SSL sockets must be closed before PSM is asked to
switch the profile.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Patch v54

This patch is mostly the latest patch in 177260, however without the portions
we already checked in.

Note that it contains some printf("=>..."); statements, to allow me some
debugging in optimized builds, I'll of course remove them prior to checking it
in.

Comment 2

[Kai Engert [:KaiE:]]

This patch has the changes to reenable the call to NSS_Shutdown as requested in
bug 187501, and it also has the code to fix the leaks as reported in bugs 189041
and 189042.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Patch v54 - subset containing only the new management classes

This is a subset, all this code is contained in the other patch, too. These are
the changes that implement the tracking and early shutdown logic. All the other
changes in the larger patch simply make use of that logic, most of it is
automatic variables that track the active context.

Comment 4

[Javier Delgadillo]

Comment on attachment 111625 [details] [diff] [review]
Patch v54

r=javi

Comment 5

[Darin Fisher]

Comment on attachment 111625 [details] [diff] [review]
Patch v54

sr=darin

Comment 6

[Kai Engert [:KaiE:]]

Patch checked in to trunk, marking fixed.

Comment 7

[John Unruh]

Verified per kaie's comments.